BUGFIX: list.reverse() is in place, does not return a value
authorSapan Bhatia <gwsapan@gmail.com>
Wed, 2 Oct 2013 13:48:42 +0000 (09:48 -0400)
committerSapan Bhatia <gwsapan@gmail.com>
Wed, 2 Oct 2013 13:48:42 +0000 (09:48 -0400)
planetstack/observer/toposort.py

index bfedee9..959cea3 100755 (executable)
@@ -36,8 +36,9 @@ def toposort(g, steps=None):
                if (not v):
                        sources.append(k)
 
-       rev_order = []
+       order = []
        marked = []
+
        while sources:
                n = sources.pop(0)
                try:
@@ -48,8 +49,9 @@ def toposort(g, steps=None):
                except KeyError:
                        pass
                if (n in steps):
-                       rev_order.append(n)
-       order = rev_order.reverse()
+                       order.append(n)
+
+       order.reverse()
 
        return order