From: Jarno Rajahalme Date: Thu, 22 Aug 2013 22:51:39 +0000 (-0700) Subject: Remove duplicate call to subfacet_create(). X-Git-Tag: sliver-openvswitch-2.0.90-1~20^2~7 X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=1607b9b580542931cd1c374053f9ef37aaff4b93;p=sliver-openvswitch.git Remove duplicate call to subfacet_create(). There were two calls to subfacet_create(), which is redundant. The first one seemed the one to remove, as there is a subsequent test on the facet's subfacet list being empty, which is never true after a call to subfacet_create(). The correctness of this needs to be checked, however. Signed-off-by: Jarno Rajahalme Signed-off-by: Ben Pfaff --- diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 6b2bd2228..c7e32ef6f 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofproto/ofproto-dpif.c @@ -3340,7 +3340,6 @@ handle_flow_miss_with_facet(struct flow_miss *miss, struct facet *facet, facet->byte_count += miss->stats.n_bytes; facet->prev_byte_count += miss->stats.n_bytes; - subfacet = subfacet_create(facet, miss); want_path = facet->xout.slow ? SF_SLOW_PATH : SF_FAST_PATH; /* Don't install the flow if it's the result of the "userspace"