From: Ben Pfaff <blp@nicira.com>
Date: Wed, 23 Feb 2011 21:05:25 +0000 (-0800)
Subject: ovs-vsctl: Clarify that uuid_from_string() shouldn't fail in post_create().
X-Git-Tag: v1.1.0~222
X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=1611cf3f5abbff87b4443d2807b369fdd327eb49;p=sliver-openvswitch.git

ovs-vsctl: Clarify that uuid_from_string() shouldn't fail in post_create().

Coverity #10701.
---

diff --git a/utilities/ovs-vsctl.c b/utilities/ovs-vsctl.c
index 3a14f7136..4435f41d1 100644
--- a/utilities/ovs-vsctl.c
+++ b/utilities/ovs-vsctl.c
@@ -3127,7 +3127,9 @@ post_create(struct vsctl_context *ctx)
     const struct uuid *real;
     struct uuid dummy;
 
-    uuid_from_string(&dummy, ds_cstr(&ctx->output));
+    if (!uuid_from_string(&dummy, ds_cstr(&ctx->output))) {
+        NOT_REACHED();
+    }
     real = ovsdb_idl_txn_get_insert_uuid(ctx->txn, &dummy);
     if (real) {
         ds_clear(&ctx->output);