From: Thierry Parmentelat <thierry.parmentelat@sophia.inria.fr>
Date: Wed, 20 Jun 2012 08:12:40 +0000 (+0200)
Subject: failing to load core modules, especially slivermanager, is very serious;
X-Git-Tag: nodemanager-2.0-37~3
X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=1d330730ef8b1c9bf18e9bc17d57ecdc759d2381;p=nodemanager.git

failing to load core modules, especially slivermanager, is very serious;
in this case display exception and exit
---

diff --git a/nodemanager.py b/nodemanager.py
index 8b2c6f6..a528140 100755
--- a/nodemanager.py
+++ b/nodemanager.py
@@ -15,16 +15,16 @@ import xmlrpclib
 import socket
 import os
 import sys
-import resource
 import glob
 import pickle
+import random
+import resource
 
 import logger
 import tools
 
 from config import Config
 from plcapi import PLCAPI
-import random
 
 
 class NodeManager:
@@ -199,7 +199,11 @@ If this is not the case, please remove the pid file %s. -- exiting""" % (other_p
                     m.start()
                     self.loaded_modules.append(m)
                 except ImportError, err:
-                    print "Warning while loading module %s:" % module, err
+                    logger.log_exc ("ERROR while loading module %s - skipping:" % module)
+                    # if we fail to load any of these, it's really no need to go on any further
+                    if module in NodeManager.core_modules:
+                        logger.log("FATAL : failed to load core module %s -- exiting"%module)
+                        sys.exit(1)
 
             # sort on priority (lower first)
             def sort_module_priority (m1,m2):