From: Ben Pfaff <blp@nicira.com>
Date: Fri, 17 May 2013 05:37:53 +0000 (-0700)
Subject: bridge: Fix use of wild pointer in iface_do_create().
X-Git-Tag: sliver-openvswitch-1.10.90-3~6^2~246
X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=2291eb080c1afe13a5d3cb3048f0d160386b714b;p=sliver-openvswitch.git

bridge: Fix use of wild pointer in iface_do_create().

'netdev' was not initialized at this point in the function, so the cleanup
at the error label referenced a wild pointer.

Introduced in commit 94a538422d4b (netdev: Prevent using reserved names).

CC: Alex Wang <alexw@nicira.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
---

diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index 28e306ea4..e10036c9a 100644
--- a/vswitchd/bridge.c
+++ b/vswitchd/bridge.c
@@ -1415,7 +1415,7 @@ iface_do_create(const struct bridge *br,
 {
     const struct ovsrec_interface *iface_cfg = if_cfg->cfg;
     const struct ovsrec_port *port_cfg = if_cfg->parent;
-    struct netdev *netdev;
+    struct netdev *netdev = NULL;
     int error;
 
     if (netdev_is_reserved_name(iface_cfg->name)) {