From: Ben Pfaff <blp@nicira.com>
Date: Mon, 12 Mar 2012 19:59:47 +0000 (-0700)
Subject: ofproto: Fix code that keeps track of MTU.
X-Git-Tag: sliver-openvswitch-0.1-1~200
X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=2666caae11db3d5e9761ef15bf6e214a9ca51af8;p=sliver-openvswitch.git

ofproto: Fix code that keeps track of MTU.

ofport_install() should set the MTU that it finds into the ofport
before calling set_internal_devs_mtu(), because the latter function might
change the MTU and update ofport->mtu and the caller should not incorrectly
overwrite its changes.

Signed-off-by: Ben Pfaff <blp@nicira.com>
---

diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index d03bd9b37..b660a1bb1 100644
--- a/ofproto/ofproto.c
+++ b/ofproto/ofproto.c
@@ -1477,8 +1477,8 @@ ofport_install(struct ofproto *p,
     shash_add(&p->port_by_name, netdev_name, ofport);
 
     if (!netdev_get_mtu(netdev, &dev_mtu)) {
-        set_internal_devs_mtu(p);
         ofport->mtu = dev_mtu;
+        set_internal_devs_mtu(p);
     } else {
         ofport->mtu = 0;
     }