From: Ben Pfaff <blp@nicira.com>
Date: Fri, 20 Apr 2012 20:51:13 +0000 (-0700)
Subject: coverage: Rate-limit logging coverage information.
X-Git-Tag: sliver-openvswitch-0.1-1~35
X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=275a506cbe10db1e673fa1182582a507ba69418e;p=sliver-openvswitch.git

coverage: Rate-limit logging coverage information.

I'd always assumed that the exponentially weighted moving average code in
timeval was enough rate-limiting, but I actually encountered a pathological
case some time ago that forced this coverage information to print once a
second or so, which seems too often.

Signed-off-by: Ben Pfaff <blp@nicira.com>
---

diff --git a/lib/coverage.c b/lib/coverage.c
index 0deb5265a..ff20f5e9c 100644
--- a/lib/coverage.c
+++ b/lib/coverage.c
@@ -158,11 +158,14 @@ coverage_log_counter(enum vlog_level level, const struct coverage_counter *c)
 void
 coverage_log(enum vlog_level level, bool suppress_dups)
 {
+    static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 3);
     size_t n_never_hit;
     uint32_t hash;
     size_t i;
 
-    if (!vlog_is_enabled(THIS_MODULE, level)) {
+    if (suppress_dups
+        ? !vlog_is_enabled(THIS_MODULE, level)
+        : vlog_should_drop(THIS_MODULE, level, &rl)) {
         return;
     }