From: Mark Huang <mlhuang@cs.princeton.edu>
Date: Mon, 16 Oct 2006 17:44:52 +0000 (+0000)
Subject: make description an optional field
X-Git-Tag: pycurl-7_13_1~568
X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=2d9b3a88df1d606e2517fa2e1e1bc421d7b370ec;p=plcapi.git

make description an optional field
---

diff --git a/PLC/Methods/AddNodeGroup.py b/PLC/Methods/AddNodeGroup.py
index 74ba2227..fe16b811 100644
--- a/PLC/Methods/AddNodeGroup.py
+++ b/PLC/Methods/AddNodeGroup.py
@@ -4,27 +4,33 @@ from PLC.Parameter import Parameter, Mixed
 from PLC.NodeGroups import NodeGroup, NodeGroups
 from PLC.Auth import PasswordAuth
 
+can_update = lambda (field, value): field in \
+             ['description']
+
 class AddNodeGroup(Method):
     """
-    Adds a new node group. Any values specified in optional_vals are used,
-    otherwise defaults are used.
+    Adds a new node group. Any values specified in nodegroup_fields
+    are used, otherwise defaults are used.
 
     Returns the new nodegroup_id (> 0) if successful, faults otherwise.
     """
 
     roles = ['admin']
 
+    update_fields = dict(filter(can_update, NodeGroup.fields.items()))
+
     accepts = [
         PasswordAuth(),
         NodeGroup.fields['name'],
-        NodeGroup.fields['description']
+        update_fields
         ]
 
     returns = Parameter(int, 'New nodegroup_id (> 0) if successful')
 
-    def call(self, auth, name, description):
-	# Create node group
-        nodegroup = NodeGroup(self.api, {'name': name, 'description': description})
+    def call(self, auth, name, nodegroup_fields = {}):
+        nodegroup_fields = dict(filter(can_update, nodegroup_fields.items()))
+        nodegroup = NodeGroup(self.api, nodegroup_fields)
+        nodegroup['name'] = name
         nodegroup.sync()
 
         return nodegroup['nodegroup_id']