From: Monam Agarwal Date: Fri, 28 Mar 2014 03:12:22 +0000 (-0700) Subject: datapath: Use with RCU_INIT_POINTER(x, NULL) in vport-gre.c X-Git-Tag: sliver-openvswitch-2.2.90-1~6^2~11 X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=317e49b4aaa71aa4e96817e035083db7f1b964f0;p=sliver-openvswitch.git datapath: Use with RCU_INIT_POINTER(x, NULL) in vport-gre.c This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL) The rcu_assign_pointer() ensures that the initialization of a structure is carried out before storing a pointer to that structure. And in the case of the NULL pointer, there is no structure to initialize. So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL) Signed-off-by: Monam Agarwal Signed-off-by: Jesse Gross --- diff --git a/datapath/vport-gre.c b/datapath/vport-gre.c index 86137565a..5ba5b8e44 100644 --- a/datapath/vport-gre.c +++ b/datapath/vport-gre.c @@ -257,7 +257,7 @@ static void gre_tnl_destroy(struct vport *vport) ovs_net = net_generic(net, ovs_net_id); - rcu_assign_pointer(ovs_net->vport_net.gre_vport, NULL); + RCU_INIT_POINTER(ovs_net->vport_net.gre_vport, NULL); ovs_vport_deferred_free(vport); gre_exit(); }