From: gggeek <giunta.gaetano@gmail.com>
Date: Tue, 17 Jan 2023 18:27:09 +0000 (+0000)
Subject: comments
X-Git-Tag: 4.10.0~139
X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=37326d28dd0fae7ff28d9aba7c9284bb82b7d2e5;p=plcapi.git

comments
---

diff --git a/src/Encoder.php b/src/Encoder.php
index ff5f99a3..d16d14c0 100644
--- a/src/Encoder.php
+++ b/src/Encoder.php
@@ -103,6 +103,7 @@ class Encoder
                                 if (function_exists('iconv')) {
                                     $dval = @iconv('UTF-8', $options['extension_api_encoding'], $val);
                                 } elseif (function_exists('mb_convert_encoding')) {
+                                    /// @todo check for discrepancies between the supported charset names
                                     $dval = @mb_convert_encoding($val, $options['extension_api_encoding'], 'UTF-8');
                                 } else {
                                     $dval = false;
diff --git a/src/PhpXmlRpc.php b/src/PhpXmlRpc.php
index fa11ed73..8781e7b9 100644
--- a/src/PhpXmlRpc.php
+++ b/src/PhpXmlRpc.php
@@ -144,6 +144,7 @@ class PhpXmlRpc
     /**
      * @var int
      * Number of decimal digits used to serialize Double values.
+     * @todo rename :'-(
      */
     public static $xmlpc_double_precision = 128;