From: Ben Pfaff <blp@nicira.com>
Date: Wed, 10 Feb 2010 19:07:28 +0000 (-0800)
Subject: ovs-brcompatd: Use error instead of pointer in handle_fdb_query_cmd().
X-Git-Tag: v1.0.0~259^2~149
X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=4869f1b170c1741fbc8f81123d0fe5fc1ba3a282;p=sliver-openvswitch.git

ovs-brcompatd: Use error instead of pointer in handle_fdb_query_cmd().

It is safe to use either value here but as long as we are saving the
error value we might as well use it.

Found by Clang (http://clang-analyzer.llvm.org/).
---

diff --git a/vswitchd/ovs-brcompatd.c b/vswitchd/ovs-brcompatd.c
index beaefb2e2..faf1bee37 100644
--- a/vswitchd/ovs-brcompatd.c
+++ b/vswitchd/ovs-brcompatd.c
@@ -756,7 +756,7 @@ handle_fdb_query_cmd(const struct ovsrec_open_vswitch *ovs,
         struct netdev *netdev;
 
         error = netdev_open_default(iface_name, &netdev);
-        if (netdev) {
+        if (!error) {
             if (!netdev_get_etheraddr(netdev, mac->addr)) {
                 n_local_macs++;
             }