From: gggeek <giunta.gaetano@gmail.com>
Date: Tue, 17 Jan 2023 13:13:07 +0000 (+0000)
Subject: comments
X-Git-Tag: 4.10.0~144
X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=6a6cc80a5e2a1c73ec825a28440faeb2994e607b;p=plcapi.git

comments
---

diff --git a/tests/3EncoderTest.php b/tests/3EncoderTest.php
index 8c44463a..507c40d8 100644
--- a/tests/3EncoderTest.php
+++ b/tests/3EncoderTest.php
@@ -100,7 +100,8 @@ class EncoderTests extends PhpXmlRpc_PolyfillTestCase
         $a = $e->decodeXml('<?xml version="1.0" encoding="US-ASCII" ?><value><string>&#8364;</string></value>');
         $this->assertEquals($string, $a->scalarVal());
 
-        /// @todo it seems that old php versions can not
+        /// @todo it seems that old php versions can not automatically transform latin to utf8 upon xml parsing.
+        ///       We should fix that, then re-enable this test
         if (version_compare(PHP_VERSION, '5.6.0', '>=')) {
             $i = $e->decodeXml('<?xml version="1.0" encoding="ISO-8859-15" ?><value><string>' . $string . '</string></value>');
             $this->assertEquals($string, $i->scalarVal());