From: Jarno Rajahalme <jrajahalme@nicira.com>
Date: Thu, 24 Oct 2013 20:19:33 +0000 (-0700)
Subject: lib/ofp-actions: Warn on deprecated actions.
X-Git-Tag: sliver-openvswitch-2.0.90-1~6^2~29
X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=6cc17de80fab26cc7392e8edc46d67cbda250283;p=sliver-openvswitch.git

lib/ofp-actions: Warn on deprecated actions.

Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
---

diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
index 2b4b45c75..77fcb8324 100644
--- a/lib/ofp-actions.c
+++ b/lib/ofp-actions.c
@@ -1105,6 +1105,24 @@ ofpact_from_openflow11(const union ofp_action *a, enum ofp_version version,
         return error;
     }
 
+    if (version >= OFP12_VERSION) {
+        switch ((int)code) {
+        case OFPUTIL_OFPAT11_SET_VLAN_VID:
+        case OFPUTIL_OFPAT11_SET_VLAN_PCP:
+        case OFPUTIL_OFPAT11_SET_DL_SRC:
+        case OFPUTIL_OFPAT11_SET_DL_DST:
+        case OFPUTIL_OFPAT11_SET_NW_SRC:
+        case OFPUTIL_OFPAT11_SET_NW_DST:
+        case OFPUTIL_OFPAT11_SET_NW_TOS:
+        case OFPUTIL_OFPAT11_SET_NW_ECN:
+        case OFPUTIL_OFPAT11_SET_TP_SRC:
+        case OFPUTIL_OFPAT11_SET_TP_DST:
+            VLOG_WARN_RL(&rl, "Deprecated action %s received over %s",
+                         ofputil_action_name_from_code(code),
+                         ofputil_version_to_string(version));
+        }
+    }
+
     switch (code) {
     case OFPUTIL_ACTION_INVALID:
 #define OFPAT10_ACTION(ENUM, STRUCT, NAME) case OFPUTIL_##ENUM: