From: Ben Pfaff <blp@nicira.com>
Date: Mon, 24 Oct 2011 22:18:49 +0000 (-0700)
Subject: datapath: Fully parenthesize ACTION macro.
X-Git-Tag: v1.4.0~252
X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=6d0840ac87f147da1e28fcf9a9ffbf9a081fa599;p=sliver-openvswitch.git

datapath: Fully parenthesize ACTION macro.

This doesn't matter for any of the current users of ACTION, nor do I expect
it to matter, but it seems like a good idea nonetheless.

Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
---

diff --git a/datapath/datapath.c b/datapath/datapath.c
index dab863133..be90d549f 100644
--- a/datapath/datapath.c
+++ b/datapath/datapath.c
@@ -552,7 +552,7 @@ static int validate_action_key(const struct nlattr *a,
 	    nla_len(ovs_key) != ovs_key_lens[key_type])
 		return -EINVAL;
 
-#define ACTION(act, key)	((act << 8) | key)
+#define ACTION(act, key)	(((act) << 8) | (key))
 
 	switch(ACTION(act_type, key_type)) {
 	const struct ovs_key_ipv4 *ipv4_key;