From: Mark Huang <mlhuang@cs.princeton.edu>
Date: Fri, 15 Dec 2006 19:40:45 +0000 (+0000)
Subject: - style nits, fix docs
X-Git-Tag: pycurl-7_13_1~190
X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=77723d1447871a37e8af77146b9586dfd3d11394;p=plcapi.git

- style nits, fix docs
---

diff --git a/PLC/Methods/AddPeer.py b/PLC/Methods/AddPeer.py
index ebb944d..d0ee32f 100644
--- a/PLC/Methods/AddPeer.py
+++ b/PLC/Methods/AddPeer.py
@@ -2,37 +2,33 @@
 # Thierry Parmentelat - INRIA
 # 
 
-from PLC.Faults import *
 from PLC.Method import Method
 from PLC.Parameter import Parameter, Mixed
 from PLC.Auth import Auth
-
 from PLC.Peers import Peer, Peers
 
-can_update = lambda(k,v): k in ['peername','peer_url','auth_person_id']
+can_update = lambda (field, value): field in \
+             ['peername', 'peer_url', 'key', 'cacert']
 
-class AddPeer (Method):
+class AddPeer(Method):
     """
-    Creates a peer entry in the database and returns its id
-    Temporarily, requires to provide an auth_person_id 
-    this is used to store the credentials that we'll
-    use when connecting to the peer's API
+    Adds a new peer.
+
+    Returns the new peer_id (> 0) if successful, faults otherwise.
     """
 
     roles = ['admin']
-    peer_fields = dict( [x for x in Peer.fields.iteritems() if can_update(x)] )
 
-    accepts = [ Auth(),
-		peer_fields
-		]
+    peer_fields = dict(filter(can_update, Peer.fields.items()))
 
-    returns = Parameter (int, "peer_id")
+    accepts = [
+        Auth(),
+        peer_fields
+        ]
 
-    def call (self, auth, fields):
+    returns = Parameter(int, "New peer_id (> 0) if successful")
 
-	peer = Peer (self.api,fields);
+    def call(self, auth, peer_fields):
+	peer = Peer(self.api, peer_fields);
 	peer.sync()
-	
 	return peer['peer_id']
-	
-