From: Mark Huang <mlhuang@cs.princeton.edu>
Date: Wed, 25 Oct 2006 16:58:00 +0000 (+0000)
Subject: - fix can_update and return value
X-Git-Tag: pycurl-7_13_1~452
X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=7ba08a2bc8fae02a93adad627c39c42cc880c88d;p=plcapi.git

- fix can_update and return value
---

diff --git a/PLC/Methods/AddConfFile.py b/PLC/Methods/AddConfFile.py
index 5b53561f..4109d1bb 100644
--- a/PLC/Methods/AddConfFile.py
+++ b/PLC/Methods/AddConfFile.py
@@ -5,14 +5,14 @@ from PLC.ConfFiles import ConfFile, ConfFiles
 from PLC.Auth import PasswordAuth
 
 can_update = lambda (field, value): field not in \
-             ['conf_file_id', 'source', 'dest', 'node_ids', 'nodegroup_ids']
+             ['conf_file_id', 'node_ids', 'nodegroup_ids']
 
 class AddConfFile(Method):
     """
     Adds a new node configuration file. Any fields specified in
     conf_file_fields are used, otherwise defaults are used.
 
-    Returns 1 if successful, faults otherwise.
+    Returns the new conf_file_id (> 0) if successful, faults otherwise.
     """
 
     roles = ['admin']
@@ -24,7 +24,7 @@ class AddConfFile(Method):
         conf_file_fields
         ]
 
-    returns = Parameter(int, '1 if successful')
+    returns = Parameter(int, 'New conf_file_id (> 0) if successful')
 
     event_type = 'Add'
     object_type = 'ConfFile'
@@ -37,4 +37,4 @@ class AddConfFile(Method):
 
 	self.object_ids = [conf_file['conf_file_id']]
 
-        return 1
+        return conf_file['conf_file_id']