From: Justin Pettit <jpettit@nicira.com>
Date: Wed, 23 Feb 2011 18:38:59 +0000 (-0800)
Subject: ovsdb-idl: Remove deadcode related to "reply" in ovsdb_idl_run().
X-Git-Tag: v1.1.0~233
X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=828cd4c7cd666b93f72d57e5932b5becf0809619;p=sliver-openvswitch.git

ovsdb-idl: Remove deadcode related to "reply" in ovsdb_idl_run().

Coverity #10705
---

diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c
index df5aff529..e7f19e4cf 100644
--- a/lib/ovsdb-idl.c
+++ b/lib/ovsdb-idl.c
@@ -282,7 +282,7 @@ ovsdb_idl_run(struct ovsdb_idl *idl)
     assert(!idl->txn);
     jsonrpc_session_run(idl->session);
     for (i = 0; jsonrpc_session_is_connected(idl->session) && i < 50; i++) {
-        struct jsonrpc_msg *msg, *reply;
+        struct jsonrpc_msg *msg;
         unsigned int seqno;
 
         seqno = jsonrpc_session_get_seqno(idl->session);
@@ -298,7 +298,6 @@ ovsdb_idl_run(struct ovsdb_idl *idl)
             break;
         }
 
-        reply = NULL;
         if (msg->type == JSONRPC_NOTIFY
                    && !strcmp(msg->method, "update")
                    && msg->params->type == JSON_ARRAY
@@ -329,9 +328,6 @@ ovsdb_idl_run(struct ovsdb_idl *idl)
                      jsonrpc_session_get_name(idl->session),
                      jsonrpc_msg_type_to_string(msg->type));
         }
-        if (reply) {
-            jsonrpc_session_send(idl->session, reply);
-        }
         jsonrpc_msg_destroy(msg);
     }