From: Ben Pfaff <blp@nicira.com>
Date: Fri, 9 Jan 2009 01:00:06 +0000 (-0800)
Subject: daemon: report error if daemon child process fails to start properly
X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=82f2a1fbd5f1730ee44ed5cc86f56126b6c15186;p=sliver-openvswitch.git

daemon: report error if daemon child process fails to start properly

Found by Chris Eagle via Fortify.
---

diff --git a/lib/daemon.c b/lib/daemon.c
index b8fc5afe5..3163657d3 100644
--- a/lib/daemon.c
+++ b/lib/daemon.c
@@ -213,7 +213,9 @@ daemonize(void)
             /* Parent process: wait for child to create pidfile, then exit. */
             close(fds[1]);
             fatal_signal_fork();
-            read(fds[0], &c, 1);
+            if (read(fds[0], &c, 1) != 1) {
+                ofp_fatal(errno, "daemon child failed to signal startup");
+            }
             exit(0);
 
         case 0: