From: Ben Pfaff Date: Tue, 23 Aug 2011 18:09:46 +0000 (-0700) Subject: ovs.stream: Fix logic bug in Stream.connect(). X-Git-Tag: v1.3.0~421 X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=9601fa824d2c3968fda75204488e347d66d62d1f;p=sliver-openvswitch.git ovs.stream: Fix logic bug in Stream.connect(). The loop here is supposed to run at least once, and to continue looping as long as the loop body changes the current state, but this bug caused it to continue looping until the connection completed in success or failure. It probably didn't cause many problems in practice because only Unix domain socket connections are currently supported, and those connections normally complete immediately. Reported-by: Reid Price --- diff --git a/python/ovs/stream.py b/python/ovs/stream.py index 21923798e..c1ce422fa 100644 --- a/python/ovs/stream.py +++ b/python/ovs/stream.py @@ -136,6 +136,7 @@ class Stream(object): returns errno.EAGAIN.""" last_state = -1 # Always differs from initial self.state while self.state != last_state: + last_state = self.state if self.state == Stream.__S_CONNECTING: self.__scs_connecting() elif self.state == Stream.__S_CONNECTED: