From: Ben Pfaff <blp@nicira.com>
Date: Fri, 6 Nov 2009 21:38:00 +0000 (-0800)
Subject: ovsdb: Fix inverted logic in ovsdb_open().
X-Git-Tag: v1.0.0~259^2~515
X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=9f2cfbfef3ce2052198a2323e443e469b18295b8;p=sliver-openvswitch.git

ovsdb: Fix inverted logic in ovsdb_open().

We want ovsdb_create() (and thus, the open database) to receive the file
only if it is a read-write database.  If it is read-only, then there is
no need to keep the file around, since we will never read or write it
after opening the database.
---

diff --git a/ovsdb/ovsdb.c b/ovsdb/ovsdb.c
index 1a4b6d8da..6d0f131ea 100644
--- a/ovsdb/ovsdb.c
+++ b/ovsdb/ovsdb.c
@@ -204,7 +204,7 @@ ovsdb_open(const char *file_name, bool read_only, struct ovsdb **dbp)
     }
     json_destroy(json);
 
-    db = ovsdb_create(read_only ? file : NULL, schema);
+    db = ovsdb_create(read_only ? NULL : file, schema);
     while ((error = ovsdb_file_read(file, &json)) == NULL && json) {
         struct ovsdb_txn *txn;