From: Ben Pfaff <blp@nicira.com>
Date: Fri, 15 Jan 2010 18:31:06 +0000 (-0800)
Subject: unixctl: Improve error reporting.
X-Git-Tag: v1.0.0~259^2~289
X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=a723bf84fb639262d2bf7e33b7640a9621bb19b5;p=sliver-openvswitch.git

unixctl: Improve error reporting.

The ovs_error() function is our standard way of reporting startup errors,
so use it.  (It also outputs the program name at the beginning of the
message.)
---

diff --git a/lib/unixctl.c b/lib/unixctl.c
index 637843941..e648cc865 100644
--- a/lib/unixctl.c
+++ b/lib/unixctl.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2008, 2009 Nicira Networks.
+ * Copyright (c) 2008, 2009, 2010 Nicira Networks.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -200,22 +200,21 @@ unixctl_server_create(const char *path, struct unixctl_server **serverp)
                                   NULL);
     if (server->fd < 0) {
         error = -server->fd;
-        fprintf(stderr, "Could not initialize control socket %s (%s)\n",
-                server->path, strerror(error));
+        ovs_error(error, "could not initialize control socket %s",
+                  server->path);
         goto error;
     }
 
     if (chmod(server->path, S_IRUSR | S_IWUSR) < 0) {
         error = errno;
-        fprintf(stderr, "Failed to chmod control socket %s (%s)\n",
-                server->path, strerror(error));
+        ovs_error(error, "failed to chmod control socket %s", server->path);
         goto error;
     }
 
     if (listen(server->fd, 10) < 0) {
         error = errno;
-        fprintf(stderr, "Failed to listen on control socket %s (%s)\n",
-                server->path, strerror(error));
+        ovs_error(error, "Failed to listen on control socket %s",
+                  server->path);
         goto error;
     }