From: gggeek <giunta.gaetano@gmail.com>
Date: Thu, 9 Feb 2023 11:09:16 +0000 (+0000)
Subject: test fixes
X-Git-Tag: 4.10.0~8
X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=acae5788dae00df24cae8aeae42570f3c1a9f9a5;p=plcapi.git

test fixes
---

diff --git a/tests/09HTTPTest.php b/tests/09HTTPTest.php
index 93da0513..b3db7df7 100644
--- a/tests/09HTTPTest.php
+++ b/tests/09HTTPTest.php
@@ -340,16 +340,17 @@ class HTTPTest extends ServerTest
         $this->client->setSSLVerifyHost($this->args['HTTPSVERIFYHOST']);
         $this->client->setUseCurl(\PhpXmlRpc\Client::USE_CURL_NEVER);
         $this->client->setSSLVersion($this->args['SSLVERSION']);
-        if (version_compare(PHP_VERSION, '8.0', '>='))
+        if (version_compare(PHP_VERSION, '8.0', '>'))
         {
             $version = explode('.', PHP_VERSION);
             $this->client->setOption(\PhpXmlRpc\Client::OPT_EXTRA_SOCKET_OPTS,
                 array('ssl' => array('security_level' => 2 + $version[1])));
+            /// @todo we should probably look deeper into the Apache config / ssl version in use to find out why this
+            ///       does not work well with TLS < 1.2
             if ($this->args['SSLVERSION'] == 0) {
-                $this->client->setSSLVersion(4 + $version[1]);
+                $this->client->setSSLVersion(5 + $version[1]);
             }
         }
-
         $this->$method();
     }