From: gggeek <giunta.gaetano@gmail.com>
Date: Sun, 13 Dec 2020 12:38:21 +0000 (+0000)
Subject: comments
X-Git-Tag: 4.4.3~34^2
X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=af311c644cddc12aaf24fed1bda2ae44cb502a7f;p=plcapi.git

comments
---

diff --git a/phpunit.xml b/phpunit.xml
index 6426cab1..cdd5e2b0 100644
--- a/phpunit.xml
+++ b/phpunit.xml
@@ -21,4 +21,4 @@
         </testsuite>
     </testsuites>
 
-</phpunit>
\ No newline at end of file
+</phpunit>
diff --git a/src/Value.php b/src/Value.php
index 24818536..3a53a788 100644
--- a/src/Value.php
+++ b/src/Value.php
@@ -38,8 +38,11 @@ class Value implements \Countable, \IteratorAggregate, \ArrayAccess
     );
 
     /// @todo: do these need to be public?
+    /** @var Value[]|mixed */
     public $me = array();
+    /** @var int $mytype */
     public $mytype = 0;
+    /** @var string|null $_php_class */
     public $_php_class = null;
 
     /**
@@ -217,13 +220,10 @@ class Value implements \Countable, \IteratorAggregate, \ArrayAccess
         switch ($this->mytype) {
             case 3:
                 return 'struct';
-                break;
             case 2:
                 return 'array';
-                break;
             case 1:
                 return 'scalar';
-                break;
             default:
                 return 'undef';
         }
@@ -387,6 +387,7 @@ class Value implements \Countable, \IteratorAggregate, \ArrayAccess
      * Return next member element for xmlrpc values of type struct.
      *
      * @return Value
+     * @throw \Error starting with php 8.0, this function should not be used, as it will always throw
      *
      * @deprecated iterate directly over the object using foreach instead
      */