From: Tony Mack <tmack@cs.princeton.edu>
Date: Tue, 11 May 2010 17:00:28 +0000 (+0000)
Subject: do not interfaces defined in registries.xml aggregates.xml if required fields arent... 
X-Git-Tag: sfa-1.0-0~197
X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=b5c2db5a919c788354f45a32085fa9d71cf91526;p=sfa.git

do not interfaces defined in registries.xml aggregates.xml if required fields arent defined or null
---

diff --git a/sfa/server/interface.py b/sfa/server/interface.py
index 05034795..4ae8e9fc 100644
--- a/sfa/server/interface.py
+++ b/sfa/server/interface.py
@@ -61,8 +61,17 @@ class Interfaces(dict):
         if not isinstance(interfaces, list):
             interfaces = [self.interfaces]
         self.interfaces = {}
+        required_fields = self.default_fields.keys()
         for interface in interfaces:
-            self.interfaces[interface['hrn']] = interface
+            valid = True
+            # skp any interface definition that has a null hrn, 
+            # address or port
+            for field in required_fields:
+                if field not in interface or not interface[field]:
+                    valid = False
+                    break
+            if valid:     
+                self.interfaces[interface['hrn']] = interface
 
 
     def sync_interfaces(self):