From: Ben Pfaff Date: Wed, 21 Aug 2013 18:33:49 +0000 (-0700) Subject: ofproto-dpif: Mark rule_release() as no_thread_safety_analysis. X-Git-Tag: sliver-openvswitch-2.0.90-1~20^2~14 X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=c1f1f653da950760c3e692d9cda7f72a47987903;p=sliver-openvswitch.git ofproto-dpif: Mark rule_release() as no_thread_safety_analysis. Otherwise new Clang complains about this function because it only sometimes releases the lock (that is, it only does it when there is a lock to release). I first noticed these warnings with Clang 1:3.4~svn188890-1~exp1. I previously used version 1:3.4~svn187484-1~exp1. Signed-off-by: Ben Pfaff --- diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 10e179cc9..6b2bd2228 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofproto/ofproto-dpif.c @@ -4849,6 +4849,7 @@ choose_miss_rule(enum ofputil_port_config config, struct rule_dpif *miss_rule, void rule_release(struct rule_dpif *rule) + OVS_NO_THREAD_SAFETY_ANALYSIS { if (rule) { ovs_rwlock_unlock(&rule->up.evict);