From: Justin Pettit Date: Fri, 12 Jul 2013 23:56:55 +0000 (-0700) Subject: ofproto-dpif: Zero-out subfacet counters when installation fails. X-Git-Tag: sliver-openvswitch-2.0.90-1~36^2~32 X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=cfd5c9eb1d9e94222d954b7f52040cd111b6640e;hp=cfd5c9eb1d9e94222d954b7f52040cd111b6640e;p=sliver-openvswitch.git ofproto-dpif: Zero-out subfacet counters when installation fails. When deleting subfacets, subfacet_uninstall() asserts that the subfacet's counters are zero to make sure we don't lose counters. We have seen cases where a subfacet cannot be installed, but the counters have values. This should not happen and indicates a bug, since we shouldn't create a subfacet if the datapath has a flow. A buggy datapath could trigger this, so just zero out the counters and log an error. Bug #18460. Signed-off-by: Justin Pettit ---