From: Tony Mack <tmack@cs.princeton.edu>
Date: Fri, 16 Jul 2010 21:23:20 +0000 (+0000)
Subject: fix bug (make sure we are removing the correct records
X-Git-Tag: sfa-1.0-0~147
X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=d1ea6f1747dbe6edb0fefc05dda8f6eed864c024;p=sfa.git

fix bug (make sure we are removing the correct records
---

diff --git a/sfa/server/interface.py b/sfa/server/interface.py
index 489d88b4..5ccb7ee3 100644
--- a/sfa/server/interface.py
+++ b/sfa/server/interface.py
@@ -145,11 +145,9 @@ class Interfaces(dict):
         """
         if not gids: 
             return
-        # get hrns we expect to find
-        # ignore records for local interfaces
-        ignore_interfaces = [self.api.config.SFA_INTERFACE_HRN]
-        hrns_expected = [gid.get_hrn() for gid in gids \
-                         if gid.get_hrn() not in ignore_interfaces]
+        
+        # hrns that should have a record
+        hrns_expected = [gid.get_hrn() for gid in gids]
 
         # get hrns that actually exist in the db
         table = SfaTable()
@@ -158,7 +156,8 @@ class Interfaces(dict):
       
         # remove old records
         for record in records:
-            if record['hrn'] not in hrns_expected:
+            if record['hrn'] not in hrns_expected and \
+                record['hrn'] != self.api.config.SFA_INTERFACE_HRN:
                 table.remove(record)
 
         # add new records