From: Ben Pfaff <blp@nicira.com>
Date: Wed, 7 Mar 2012 21:52:55 +0000 (-0800)
Subject: ovs-ofctl: Avoid segfault upon receive error for "monitor", "snoop".
X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=d3489723f561d6586833a2eca29cfffcd7d70033;p=sliver-openvswitch.git

ovs-ofctl: Avoid segfault upon receive error for "monitor", "snoop".

Bug #10062.
Reported-by: James Schmidt <jschmidt@nicira.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
---

diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c
index d2efd7f23..786221e40 100644
--- a/utilities/ovs-ofctl.c
+++ b/utilities/ovs-ofctl.c
@@ -988,9 +988,9 @@ monitor_vconn(struct vconn *vconn)
             if (retval == EAGAIN) {
                 break;
             }
-            msg_type = ((const struct ofp_header *) b->data)->type;
-
             run(retval, "vconn_recv");
+
+            msg_type = ((const struct ofp_header *) b->data)->type;
             ofp_print(stderr, b->data, b->size, verbosity + 2);
             ofpbuf_delete(b);