From: Tony Mack <tmack@paris.CS.Princeton.EDU>
Date: Thu, 30 Aug 2012 03:04:43 +0000 (-0400)
Subject: in delete_instances(), wait until instance is destroyed until attempting to delete... 
X-Git-Tag: sfa-3.0-0~126
X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=dbe9e9bbf064bf4a21b1d60e725f6d690127c548;p=sfa.git

in delete_instances(), wait until instance is destroyed until attempting to delete instance's security groups. Wait for at most 10 seconds. Executes in a separate thread so main call is not blocked:
---

diff --git a/sfa/openstack/osaggregate.py b/sfa/openstack/osaggregate.py
index a4c0763e..cb40a081 100644
--- a/sfa/openstack/osaggregate.py
+++ b/sfa/openstack/osaggregate.py
@@ -356,6 +356,21 @@ class OSAggregate:
 
 
     def delete_instance(self, tenant_name, instance_name, id=None):
+    
+        def _delete_security_group(instance):
+            security_group = instance.metadata.get('security_groups', '')
+            if security_group:
+                manager = SecurityGroup(self.driver)
+                timeout = 10.0 # wait a maximum of 10 seconds before forcing the security group delete
+                start_time = time.time()
+                instance_deleted = False
+                while instance_deleted == False and (time.time() - start_time) < timeout:
+                    inst = self.driver.shell.nova_manager.servers.findall(id=instance.id)
+                    if not inst:
+                        instance_deleted = True
+                manager.delete_security_group(security_group)
+
+        thread_manager = ThreadManager() 
         self.driver.shell.nova_manager.connect(tenant=tenant_name)
         args = {'name': instance_name}
         if id:
@@ -363,14 +378,10 @@ class OSAggregate:
         instances = self.driver.shell.nova_manager.servers.findall(**args)
         security_group_manager = SecurityGroup(self.driver)
         for instance in instances:
-            # deleate this instance's security groups
-            security_group = instance.metadata.get('security_groups', '')
-            if security_group:
-                # dont delete the default security group
-                if security_group != 'default': 
-                    security_group_manager.delete_security_group(security_group)
             # destroy instance
             self.driver.shell.nova_manager.servers.delete(instance)
+            # deleate this instance's security groups
+            thread_manager.run(_delete_security_group, instance)
         return 1
 
     def stop_instances(self, instance_name, tenant_name, id=None):