From: Mark Huang <mlhuang@cs.princeton.edu>
Date: Thu, 7 Sep 2006 23:47:55 +0000 (+0000)
Subject: - fix accidental modification of class variable
X-Git-Tag: pycurl-7_13_1~783
X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=eae096fafed0efd0fd3d392c772aac9f3a5a731c;p=plcapi.git

- fix accidental modification of class variable
---

diff --git a/PLC/Methods/AdmGetNodes.py b/PLC/Methods/AdmGetNodes.py
index c38b8d4..e7ca17f 100644
--- a/PLC/Methods/AdmGetNodes.py
+++ b/PLC/Methods/AdmGetNodes.py
@@ -44,15 +44,17 @@ class AdmGetNodes(Method):
         # Authenticated function
         assert self.caller is not None
 
+        valid_fields = dict(self.return_fields)
+
         # Remove admin only fields
         if 'admin' not in self.caller['roles']:
             for key in ['boot_nonce', 'key', 'session', 'root_person_ids']:
-                del self.return_fields[key]
+                del valid_fields[key]
 
         # Make sure that only valid fields are specified
         if return_fields is None:
-            return_fields = self.return_fields
-        elif filter(lambda field: field not in self.return_fields, return_fields):
+            return_fields = valid_fields
+        elif filter(lambda field: field not in valid_fields, return_fields):
             raise PLCInvalidArgument, "Invalid return field specified"
 
         # Get node information