From: Sapan Bhatia <gwsapan@gmail.com>
Date: Mon, 18 Aug 2014 06:24:22 +0000 (-0400)
Subject: Trying to commit an unsaved object with fields set causes the database
X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=f1d3d273b14a40859229c0d03bc4b2b16e2d93c2;p=plstackapi.git

Trying to commit an unsaved object with fields set causes the database
to lock up.
---

diff --git a/planetstack/ec2_observer/syncstep.py b/planetstack/ec2_observer/syncstep.py
index d5f7523..31fec04 100644
--- a/planetstack/ec2_observer/syncstep.py
+++ b/planetstack/ec2_observer/syncstep.py
@@ -86,7 +86,8 @@ class SyncStep:
                 except:
                     o.backend_status = str(e)
 
-                o.save(update_fields=['backend_status'])
+                if (o.pk):
+                    o.save(update_fields=['backend_status'])
 
                 logger.log_exc("sync step failed!")
                 failed.append(o)
diff --git a/planetstack/openstack_observer/syncstep.py b/planetstack/openstack_observer/syncstep.py
index c77c8d5..324829d 100644
--- a/planetstack/openstack_observer/syncstep.py
+++ b/planetstack/openstack_observer/syncstep.py
@@ -84,7 +84,8 @@ class SyncStep:
                 except:
                     o.backend_status = str(e)
 
-                o.save(update_fields=['backend_status'])
+                if (o.pk):
+                    o.save(update_fields=['backend_status'])
 
                 logger.log_exc("sync step failed!")
                 failed.append(o)