From: Ben Pfaff <blp@nicira.com>
Date: Thu, 4 Nov 2010 20:49:19 +0000 (-0700)
Subject: datapath: Use struct assignment in place of memcpy() for copying stats.
X-Git-Tag: v1.1.0~898
X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=f493a3fc144adf053c6bb2cf446300c65e9e22c3;p=sliver-openvswitch.git

datapath: Use struct assignment in place of memcpy() for copying stats.

We might as well take advantage of type safety when we can get it.

Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
---

diff --git a/datapath/vport.c b/datapath/vport.c
index 6c8eb0845..f0c81823f 100644
--- a/datapath/vport.c
+++ b/datapath/vport.c
@@ -910,7 +910,7 @@ int vport_set_stats(struct vport *vport, struct odp_vport_stats *stats)
 
 	if (vport->ops->flags & VPORT_F_GEN_STATS) {
 		spin_lock_bh(&vport->stats_lock);
-		memcpy(&vport->offset_stats, stats, sizeof(struct odp_vport_stats));
+		vport->offset_stats = *stats;
 		spin_unlock_bh(&vport->stats_lock);
 
 		return 0;
@@ -1030,7 +1030,7 @@ int vport_get_stats(struct vport *vport, struct odp_vport_stats *stats)
 
 		spin_lock_bh(&vport->stats_lock);
 
-		memcpy(stats, &vport->offset_stats, sizeof(struct odp_vport_stats));
+		*stats = vport->offset_stats;
 
 		stats->rx_errors	+= vport->err_stats.rx_errors
 						+ vport->err_stats.rx_frame_err