From: Ben Pfaff <blp@nicira.com>
Date: Sun, 13 May 2012 23:34:49 +0000 (-0700)
Subject: Avoid writes to variables that are never read back.
X-Git-Tag: sliver-openvswitch-1.8.90-0~48^2~442
X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=f5cd6874f1e4efcd1d513a294bf7709933959b97;p=sliver-openvswitch.git

Avoid writes to variables that are never read back.

Found by clang.

Signed-off-by: Ben Pfaff <blp@nicira.com>
---

diff --git a/lib/ofp-print.c b/lib/ofp-print.c
index 7479bf222..1757a30c3 100644
--- a/lib/ofp-print.c
+++ b/lib/ofp-print.c
@@ -480,7 +480,7 @@ ofp_print_bit_names(struct ds *string, uint32_t bits,
     }
 
     if (bits) {
-        if (n++) {
+        if (n) {
             ds_put_char(string, ' ');
         }
         ds_put_format(string, "0x%"PRIx32, bits);
diff --git a/utilities/ovs-vsctl.c b/utilities/ovs-vsctl.c
index 2fc87f002..d8aeb53d8 100644
--- a/utilities/ovs-vsctl.c
+++ b/utilities/ovs-vsctl.c
@@ -3809,8 +3809,6 @@ do_vsctl(const char *args, struct vsctl_command *commands, size_t n_commands,
 
         if (ctx.try_again) {
             vsctl_context_done(&ctx, NULL);
-
-            status = TXN_TRY_AGAIN;
             goto try_again;
         }
     }