From: gggeek Date: Sat, 23 May 2015 20:13:49 +0000 (+0100) Subject: Fix buildWrapFunctionSource which had been forgotten when moving analyzed phpdoc... X-Git-Tag: 4.0.0-alpha^2~42 X-Git-Url: http://git.onelab.eu/?a=commitdiff_plain;h=fad2b474319b54adea5d1b16c135b7fde389c8dc;p=plcapi.git Fix buildWrapFunctionSource which had been forgotten when moving analyzed phpdoc params to named instead of positional --- diff --git a/src/Wrapper.php b/src/Wrapper.php index 6529950c..4b70dc18 100644 --- a/src/Wrapper.php +++ b/src/Wrapper.php @@ -308,8 +308,8 @@ class Wrapper return array( 'desc' => $desc, 'docs' => $docs, - 'params' => $params, - 'paramDocs' => $paramDocs, + 'params' => $params, // array, positionally indexed + 'paramDocs' => $paramDocs, // array, indexed by name 'returns' => $returns, 'returnsDocs' =>$returnsDocs, ); @@ -496,11 +496,11 @@ class Wrapper $pars = array(); $pNum = count($funcDesc['params']); foreach ($funcDesc['params'] as $param) { - if (isset($funcDesc['paramDocs'][$i]['name']) && $funcDesc['paramDocs'][$i]['name'] && - strtolower($funcDesc['paramDocs'][$i]['name']) != strtolower($param['name'])) { - // param name from phpdoc info does not match param definition! - $funcDesc['paramDocs'][$i]['type'] = 'mixed'; - } + /*$name = strtolower($funcDesc['params'][$i]['name']); + if (!isset($funcDesc['paramDocs'][$name])) { + // no param found in phpdoc info matching param definition! + $funcDesc['paramDocs'][$name]['type'] = 'mixed'; + }*/ if ($param['isoptional']) { // this particular parameter is optional. save as valid previous list of parameters