From 2eb053125001b1d663e3e3692af9450648eff9b6 Mon Sep 17 00:00:00 2001 From: Ben Pfaff Date: Wed, 28 Mar 2012 14:02:57 -0700 Subject: [PATCH] ovsdb-idl: Fix memory leak writing synthetic rows in ovsdb_idl_txn_write(). This could cause a slow but steady memory leak in ovs-vswitchd. Found by valgrind. Signed-off-by: Ben Pfaff --- lib/ovsdb-idl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c index 19ae16fe5..5ad3f5cd9 100644 --- a/lib/ovsdb-idl.c +++ b/lib/ovsdb-idl.c @@ -1,4 +1,4 @@ -/* Copyright (c) 2009, 2010, 2011 Nicira Networks. +/* Copyright (c) 2009, 2010, 2011, 2012 Nicira Networks. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -1718,6 +1718,7 @@ ovsdb_idl_txn_write(const struct ovsdb_idl_row *row_, size_t column_idx; if (ovsdb_idl_row_is_synthetic(row)) { + ovsdb_datum_destroy(datum, &column->type); return; } -- 2.43.0