From f99cfc8401815836073effa34c5cda024e77a3a9 Mon Sep 17 00:00:00 2001
From: Thierry Parmentelat <thierry.parmentelat@sophia.inria.fr>
Date: Mon, 9 Mar 2009 12:06:45 +0000
Subject: [PATCH] update

---
 modules/planetlab.module            |   6 +-
 planetlab/common/about.php          |   4 +-
 planetlab/css/plc_style.css         |   5 +-
 planetlab/nodes/interface.php       |   2 +-
 planetlab/nodes/node.php            |  18 +-
 planetlab/nodes/node_downloads.php  |   6 +-
 planetlab/persons/person.php        |   8 +-
 planetlab/persons/register.php      |   6 +-
 planetlab/sites/join_request.php    |   4 +-
 planetlab/sites/site.php            |  16 +-
 planetlab/sites/site_form.php       |   2 +-
 planetlab/tags/nodegroup.php        |   2 +-
 planetlab/tags/tag.php              |   6 +-
 plekit/linetabs/linetabs.css        |  10 +
 plekit/linetabs/linetabs.js         |   6 +-
 plekit/niftycorner/niftyCorners.css |  35 ++++
 plekit/niftycorner/niftycube.js     | 298 ++++++++++++++++++++++++++++
 plekit/php/details.php              |  14 +-
 plekit/php/form.php                 |   9 +-
 plekit/php/linetabs.php             |  22 +-
 plekit/php/table.php                |  26 +--
 plekit/php/toggle.php               |  22 +-
 plekit/table/table.css              |   7 +
 plekit/toggle/toggle.css            |  16 +-
 24 files changed, 458 insertions(+), 92 deletions(-)
 create mode 100755 plekit/niftycorner/niftyCorners.css
 create mode 100755 plekit/niftycorner/niftycube.js

diff --git a/modules/planetlab.module b/modules/planetlab.module
index 857ebd6..4df1b15 100644
--- a/modules/planetlab.module
+++ b/modules/planetlab.module
@@ -53,10 +53,10 @@ function planetlab_menu($may_cache) {
 }
 
 // formatting helpers
-function ul_start () { return '<ul class=menu>'; }
+function ul_start () { return '<ul class="menu">'; }
 function ul_end () { return '</ul>'; }
-function leaf($text) { return '<li class=leaf>' . $text . '</li>'; }
-function expanded($text) { return '<li class=expanded>' . $text . '</li>'; }
+function leaf($text) { return '<li class="leaf">' . $text . '</li>'; }
+function expanded($text) { return '<li class="expanded">' . $text . '</li>'; }
 function p($text) { return '<p>' . $text . '</p>'; }
 // fake theme to look like menu
 function menu_theme ($menu) {
diff --git a/planetlab/common/about.php b/planetlab/common/about.php
index e558577..f232ec0 100644
--- a/planetlab/common/about.php
+++ b/planetlab/common/about.php
@@ -23,8 +23,8 @@ print "<table><tbody>\n";
 
 foreach ( array( "build", "tags", "rpms" ) as $field) {
 
-  print "<tr><th colspan=2 align='center'></th></tr>\n";
-  print "<tr><th colspan=2 align='center'><h2>" . ucwords($field . " details") . "</h2></th></tr>\n";
+  print "<tr><th colspan='2' align='center'></th></tr>\n";
+  print "<tr><th colspan='2' align='center'><h2>" . ucwords($field . " details") . "</h2></th></tr>\n";
   $keys=array_keys($release[$field]);
   usort($keys,"__cmp_lower");
 
diff --git a/planetlab/css/plc_style.css b/planetlab/css/plc_style.css
index 670d252..1740333 100644
--- a/planetlab/css/plc_style.css
+++ b/planetlab/css/plc_style.css
@@ -39,7 +39,4 @@ body {
 *.plc-warning a:visited { text-decoration: none; color:white }
 *.plc-warning a:hover { text-decoration: none; color:black }
 
-/* separator below the linetabs area */
-p.plc-linetabs {
-    height:15px;
-}
+.addresses { text-align: center; font-weight: bold; }
diff --git a/planetlab/nodes/interface.php b/planetlab/nodes/interface.php
index a922a73..f2e7e88 100644
--- a/planetlab/nodes/interface.php
+++ b/planetlab/nodes/interface.php
@@ -138,7 +138,7 @@ if ($mode == 'add') return;
 
 
 //////////////////////////////////////// tags
-$toggle=new PlekitToggle ('tags','Tags',array('trigger-tagname'=>'h2'));
+$toggle=new PlekitToggle ('tags','Tags');
 $toggle->start();
 
 $form = new PlekitForm (l_actions(),array('interface_id'=>$interface_id));
diff --git a/planetlab/nodes/node.php b/planetlab/nodes/node.php
index a1e6221..2ebc3f4 100644
--- a/planetlab/nodes/node.php
+++ b/planetlab/nodes/node.php
@@ -227,9 +227,9 @@ if ( $local_peer ) {
   $tagnames = array_map ("get_tagname",$tags);
   $nodegroups_hash=plc_nodegroup_global_hash($api,$tagnames);
   
-  $toggle = new PlekitToggle ('tags',"Tags",array('trigger-tagname'=>'h2',
-					       'trigger-bubble'=>'Inspect and set tags on that node',
-					       'start-visible'=>$show_tags));
+  $toggle = new PlekitToggle ('tags',"Tags",
+			      array('trigger-bubble'=>'Inspect and set tags on that node',
+				    'start-visible'=>$show_tags));
   $toggle->start();
 
   $headers=array("Name"=>"string",
@@ -285,9 +285,9 @@ if ( $local_peer ) {
 
 //////////////////////////////////////////////////////////// interfaces
 if ( $local_peer ) {
-  $toggle=new PlekitToggle ('interfaces',"Interfaces",array('trigger-tagname'=>'h2',
-							 'trigger-bubble'=>'Inspect and tune interfaces on that node',
-							 'start-hidden'=>true));
+  $toggle=new PlekitToggle ('interfaces',"Interfaces",
+			    array('trigger-bubble'=>'Inspect and tune interfaces on that node',
+				  'start-hidden'=>true));
   $toggle->start();
   // display interfaces
   if( ! $interfaces ) {
@@ -358,9 +358,9 @@ if ( $local_peer ) {
 // display slices
 
 {
-  $toggle=new PlekitToggle ('slices',"Slices",array('trigger-tagname'=>'h2',
-						 'trigger-bubble'=>'Review slices running on that node',
-						 'start-hidden'=>true));
+  $toggle=new PlekitToggle ('slices',"Slices",
+			    array('trigger-bubble'=>'Review slices running on that node',
+				  'start-hidden'=>true));
   $toggle->start();
   if ( ! $slices  ) {
     plc_warning ("This node is not associated to any slice");
diff --git a/planetlab/nodes/node_downloads.php b/planetlab/nodes/node_downloads.php
index 8cbe6d3..8af032b 100644
--- a/planetlab/nodes/node_downloads.php
+++ b/planetlab/nodes/node_downloads.php
@@ -260,14 +260,14 @@ EOF;
 if( $has_primary ) {
   print( "<table border=\"0\" cellspacing=\"4\">\n" );
   
-  print( "<tr><th colspan=2><a href='index.php?id=$node_id'>Node Details</a></th></tr>" );
+  print( "<tr><th colspan='2'><a href='index.php?id=$node_id'>Node Details</a></th></tr>" );
   print( "<tr><th>node_id:</th>" );
   print( "<td>$node_id</td></tr>\n" );
   print( "<tr><th>Hostname:</th>" );
   print( "<td>" . $node_detail['hostname'] . "</td></tr>\n" );
 
   $nn_id = $interface_detail['interface_id'];
-  print( "<tr><th colspan=2><a href='interface.php?id=$nn_id'>Interface Details</a></th></tr>" );
+  print( "<tr><th colspan='2'><a href='interface.php?id=$nn_id'>Interface Details</a></th></tr>" );
 
   print( "<tr><th>Method:</th>" );
   print( "<td>" . $interface_detail['method'] . "</td></tr>\n" );
@@ -293,7 +293,7 @@ if( $has_primary ) {
       }
     }
 
-  print ("<tr><th colspan=2><a href='interface.php?id=$nn_id'>Additional Settings</a></th></tr>\n");
+  print ("<tr><th colspan='2'><a href='interface.php?id=$nn_id'>Additional Settings</a></th></tr>\n");
   $nn_id = $interface_detail['interface_id'];
   $settings=$api->GetInterfaceTags(array("interface_id" => array($nn_id)));
   foreach ($settings as $setting) {
diff --git a/planetlab/persons/person.php b/planetlab/persons/person.php
index 968a7d8..ff630e8 100644
--- a/planetlab/persons/person.php
+++ b/planetlab/persons/person.php
@@ -160,7 +160,7 @@ $details->end();
 $details->form_end();
 
 //////////////////// slices
-$toggle=new PlekitToggle ('slices','Slices',array('trigger-tagname'=>'h2'));
+$toggle=new PlekitToggle ('slices','Slices');
 $toggle->start();
 
 if( ! $slices) {
@@ -192,7 +192,7 @@ $form=new PlekitForm(l_actions(), array("person_id"=>$person_id));
 $form->start();
 
 //////////////////// keys
-$toggle=new PlekitToggle ('keys',"Keys",array('trigger-tagname'=>'h2'));
+$toggle=new PlekitToggle ('keys',"Keys");
 $toggle->start();
 		
 $can_manage_keys = ( $local_peer && ( plc_is_admin() || $is_my_account) );
@@ -240,7 +240,7 @@ $table->end();
 $toggle->end();
 
 //////////////////// sites
-$toggle=new PlekitToggle('sites','Sites',array('trigger-tagname'=>'h2'));
+$toggle=new PlekitToggle('sites','Sites');
 $toggle->start();
   
 if (empty( $sites ) ) {
@@ -293,7 +293,7 @@ $table->end();
 $toggle->end();
 
 //////////////////// roles
-$toggle=new PlekitToggle ('roles','Roles',array('trigger-tagname'=>'h2'));
+$toggle=new PlekitToggle ('roles','Roles');
 $toggle->start();
 
 if (! $roles) plc_warning ("This user has no role !");
diff --git a/planetlab/persons/register.php b/planetlab/persons/register.php
index 94a27d6..4ff23b9 100644
--- a/planetlab/persons/register.php
+++ b/planetlab/persons/register.php
@@ -282,8 +282,8 @@ foreach ($form as $name => $item) {
 
   if ( ! empty($item['comment'])) {
     $comment=$item['comment'];
-    print "<tr><td colspan=2> &nbsp; </td></tr>";
-    print "<tr><td colspan=2> $comment: </td></tr>";
+    print "<tr><td colspan='2'> &nbsp; </td></tr>";
+    print "<tr><td colspan='2'> $comment: </td></tr>";
   }
 
   $title = $item['title'];
@@ -334,7 +334,7 @@ EOF;
 
 // Do not allow resubmits
 if (empty($person['person_id'])) {
-  print '<tr><td colspan=2><input type="submit" name="op" value="Register"  class="form-submit" /></td></tr>';
+  print '<tr><td colspan='2'><input type="submit" name="op" value="Register"  class="form-submit" /></td></tr>';
 }
 
 print <<<EOF
diff --git a/planetlab/sites/join_request.php b/planetlab/sites/join_request.php
index 48dafd8..494b283 100644
--- a/planetlab/sites/join_request.php
+++ b/planetlab/sites/join_request.php
@@ -94,7 +94,7 @@ EOF;
   // display the buttons 
   print <<< EOF
     <tr>
-    <td colspan=2>
+    <td colspan='2'>
     <table width="100%" border=0 cellspacing="0" cellpadding="5"> <tr> 
     <td align=center><input type="submit" name="submitted" value="Delete"></td>
     <td align=center><input type="submit" name="submitted" value="Update"></td>
@@ -109,7 +109,7 @@ EOF;
   // display the buttons 
   print <<< EOF
     <tr>
-    <td colspan=2>
+    <td colspan='2'>
     <table width="100%" border=0 cellspacing="0" cellpadding="5"> <tr> 
     <td align=center><input type="submit" name="submitted" value="Delete"></td>
     <td align=center><input type="submit" name="submitted" value="Update"></td>
diff --git a/planetlab/sites/site.php b/planetlab/sites/site.php
index 57d89f5..81cb990 100644
--- a/planetlab/sites/site.php
+++ b/planetlab/sites/site.php
@@ -149,9 +149,10 @@ $details = new PlekitDetails($can_update);
 if ( ! $site['is_public']) 
   plc_warning("This site is not public!");
 
+$details->form_start(l_actions(),array('action'=>'update-site','site_id'=>$site_id));
+
 $details->start();
 
-$details->form_start(l_actions(),array('action'=>'update-site','site_id'=>$site_id));
 $details->th_td("Full name",$sitename,'name',array('width'=>50));
 $details->th_td("Abbreviated name",$abbreviated_name,'abbreviated_name',array('width'=>15));
 $details->th_td("URL",$site_url,'url',array('width'=>40));
@@ -168,13 +169,13 @@ if (plc_is_admin())
 else
   $details->th_td("Max slices",$max_slices);
 $details->tr_submit("submit","Update Site");
-$details->form_end();
 
 if ( ! $local_peer) {
   $details->space();
   $details->th_td("Peer",$peers->peer_link($peer_id));
  }
 $details->end();
+$details->form_end();
 
 //////////////////// mode details - for local object
 if ( $local_peer ) {
@@ -191,7 +192,7 @@ if ( $local_peer ) {
     $nodes_title = plc_warning_html ($nodes_title);
   $nodes_title .= href(l_nodes_site($site_id)," (See as nodes)");
 
-  $toggle=new PlekitToggle ('nodes',$nodes_title,array('trigger-tagname'=>'h2'));
+  $toggle=new PlekitToggle ('nodes',$nodes_title);
   $toggle->start();
 
   $headers=array();
@@ -227,7 +228,7 @@ if ( $local_peer ) {
     $persons_title = plc_warning_html ($persons_title);
   $persons_title .= href(l_persons_site($site_id)," (See as users)");
 
-  $toggle=new PlekitToggle ('persons',$persons_title,array('trigger-tagname'=>'h2'));
+  $toggle=new PlekitToggle ('persons',$persons_title);
   $toggle->start();
 
   $headers = array ();
@@ -254,7 +255,7 @@ if ( $local_peer ) {
 
   //////////////////// Slices
   // xxx to review after slices gets reworked
-  $toggle=new PlekitToggle ('slices',"Slices",array('trigger-tagname'=>'h2'));
+  $toggle=new PlekitToggle ('slices',"Slices");
   $toggle->start();
   $details=new PlekitDetails (false);
   $details->start();
@@ -271,11 +272,10 @@ if ( $local_peer ) {
   $toggle->end();
 
   // Addresses
-  $toggle=new PlekitToggle ('addresses',"Addresses",array('trigger-tagname'=>'h2',
-						       'start-visible'=>false));
+  $toggle=new PlekitToggle ('addresses',"Addresses",array('start-visible'=>false));
   $toggle->start();
   if ( ! $addresses) {
-    print "No known address for this site";
+    print "<p class='addresses'>No known address for this site</p>";
   } else {
     $details=new PlekitDetails (false);
     $details->start();
diff --git a/planetlab/sites/site_form.php b/planetlab/sites/site_form.php
index 7304e95..bc54821 100644
--- a/planetlab/sites/site_form.php
+++ b/planetlab/sites/site_form.php
@@ -189,7 +189,7 @@ function form_render_table2 ($form, $input, $outline_missing) {
     // render the comment field
     if ( ! empty($item['comment'])) {
       $comment=$item['comment'];
-      print "<tr><td colspan=2> $comment </td></tr>";
+      print "<tr><td colspan='2'> $comment </td></tr>";
     }
 
     // compute line attributes
diff --git a/planetlab/tags/nodegroup.php b/planetlab/tags/nodegroup.php
index 4c43fed..86b7e6d 100644
--- a/planetlab/tags/nodegroup.php
+++ b/planetlab/tags/nodegroup.php
@@ -61,7 +61,7 @@ $details->th_td("# nodes",count($nodegroup['node_ids']));
 $details->end();
 
 // xxx : add & delete buttons would make sense here too
-$toggle=new PlekitToggle('nodes',"Nodes",array('trigger-tagname'=>'h2'));
+$toggle=new PlekitToggle('nodes',"Nodes");
 $toggle=>start();
 
 $headers["Hostname"]="string";
diff --git a/planetlab/tags/tag.php b/planetlab/tags/tag.php
index 7d5e521..675594d 100644
--- a/planetlab/tags/tag.php
+++ b/planetlab/tags/tag.php
@@ -90,7 +90,7 @@ $table_options=array('notes_area'=>false, 'pagesize_area'=>false, 'search_width'
 
 // xxx could outline values corresponding to a nodegroup
 if (count ($node_tags)) {
-  $toggle=new PlekitToggle('tag_nodes',"Nodes",array('trigger-tagname'=>'h2'));
+  $toggle=new PlekitToggle('tag_nodes',"Nodes");
   $toggle->start();
   $table=new PlekitTable ("tag_nodes",array("Hostname"=>"string","value"=>"string"),0,$table_options);
   $table->start();
@@ -105,7 +105,7 @@ if (count ($node_tags)) {
  }
 
 if (count ($interface_tags)) {
-  $toggle=new PlekitToggle('tag_interfaces',"Interfaces",array('trigger-tagname'=>'h2'));
+  $toggle=new PlekitToggle('tag_interfaces',"Interfaces");
   $toggle->start();
   $table=new PlekitTable ("tag_interfaces",array("IP"=>"IPAddress","value"=>"string"),0,$table_options);
   $table->start();
@@ -123,7 +123,7 @@ if (count ($interface_tags)) {
 // xxx don't show hostnames yet
 $slice_tags = array_merge ($slice_tags,$sliver_tags);
 if (count ($slice_tags)) {
-  $toggle=new PlekitToggle('tag_slices',"Slice and sliver tags",array('trigger-tagname'=>'h2'));
+  $toggle=new PlekitToggle('tag_slices',"Slice and sliver tags");
   $toggle->start();
   $table=new PlekitTable ("tag_slices",array("Slice"=>"string","value"=>"string","Node id"=>"int"),0,$table_options);
   $table->start();
diff --git a/plekit/linetabs/linetabs.css b/plekit/linetabs/linetabs.css
index 8f44090..525fd32 100644
--- a/plekit/linetabs/linetabs.css
+++ b/plekit/linetabs/linetabs.css
@@ -1,5 +1,10 @@
 /* $Id$ */
 
+/* clear browser-dependant defaults */
+div.linetabs * {
+    padding: 0; margin: 0; border: 0;
+}
+
 div.linetabs {
     padding: 20px;
     margin: 8px 0;
@@ -67,3 +72,8 @@ div.linetabs>ul>li input.active {
     margin-bottom: 0px;
 }
 
+/* separator below the linetabs area */
+p.linetabs {
+    height:15px;
+    clear: both;
+}
diff --git a/plekit/linetabs/linetabs.js b/plekit/linetabs/linetabs.js
index 8ecf5eb..834d756 100644
--- a/plekit/linetabs/linetabs.js
+++ b/plekit/linetabs/linetabs.js
@@ -203,6 +203,6 @@ var linetabs_namespace = {
  
 };
  
-window.onload   = linetabs_namespace.init;
-window.onunload = linetabs_namespace.cleanUp;
-window.onresize = linetabs_namespace.resize;
+Event.observe(window, 'load',linetabs_namespace.init);
+Event.observe(window, 'unload', linetabs_namespace.cleanUp);
+Event.observe(window, 'resize', linetabs_namespace.resize);
diff --git a/plekit/niftycorner/niftyCorners.css b/plekit/niftycorner/niftyCorners.css
new file mode 100755
index 0000000..6570f60
--- /dev/null
+++ b/plekit/niftycorner/niftyCorners.css
@@ -0,0 +1,35 @@
+/*Nifty Corners Cube CSS by Alessandro Fulciniti
+The following classes are added dinamically by javascript,
+and their use should be avoided in the markup */
+
+b.niftycorners,b.niftyfill{display:block}
+b.niftycorners *{display:block;height: 1px;line-height:1px;font-size: 1px;
+    overflow:hidden;border-style:solid;border-width: 0 1px}
+/*normal*/
+b.r1{margin: 0 3px;border-width: 0 2px}
+b.r2{margin: 0 2px}
+b.r3{margin: 0 1px}
+b.r4{height: 2px}
+b.rb1{margin: 0 8px;border-width:0 2px}
+b.rb2{margin: 0 6px;border-width:0 2px}
+b.rb3{margin: 0 5px}
+b.rb4{margin: 0 4px}
+b.rb5{margin: 0 3px}
+b.rb6{margin: 0 2px}
+b.rb7{margin: 0 1px;height:2px}
+b.rb8{margin: 0;height:2px}
+b.rs1{margin: 0 1px}
+/*transparent inside*/
+b.t1{border-width: 0 5px}
+b.t2{border-width: 0 3px}
+b.t3{border-width: 0 2px}
+b.t4{height: 2px}
+b.tb1{border-width: 0 10px}
+b.tb2{border-width: 0 8px}
+b.tb3{border-width: 0 6px}
+b.tb4{border-width: 0 5px}
+b.tb5{border-width: 0 4px}
+b.tb6{border-width: 0 3px}
+b.tb7{border-width: 0 2px;height:2px}
+b.tb8{border-width: 0 1px;height:2px}
+b.ts1{border-width: 0 2px}
\ No newline at end of file
diff --git a/plekit/niftycorner/niftycube.js b/plekit/niftycorner/niftycube.js
new file mode 100755
index 0000000..ef1e53f
--- /dev/null
+++ b/plekit/niftycorner/niftycube.js
@@ -0,0 +1,298 @@
+/* Nifty Corners Cube - rounded corners with CSS and Javascript
+Copyright 2006 Alessandro Fulciniti (a.fulciniti@html.it)
+
+This program is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 2 of the License, or
+(at your option) any later version.
+
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with this program; if not, write to the Free Software
+Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+*/
+
+var niftyOk=(document.getElementById && document.createElement && Array.prototype.push);
+var niftyCss=false;
+
+String.prototype.find=function(what){
+return(this.indexOf(what)>=0 ? true : false);
+}
+
+var oldonload=window.onload;
+if(typeof(NiftyLoad)!='function') NiftyLoad=function(){};
+if(typeof(oldonload)=='function')
+    window.onload=function(){oldonload();AddCss('/plekit/niftycorner');NiftyLoad()};
+else window.onload=function(){AddCss('/plekit/niftycorner');NiftyLoad()};
+
+function AddCss(path){
+niftyCss=true;
+var l=CreateEl("link");
+l.setAttribute("type","text/css");
+l.setAttribute("rel","stylesheet");
+l.setAttribute("href",path+"/niftyCorners.css");
+l.setAttribute("media","screen");
+document.getElementsByTagName("head")[0].appendChild(l);
+}
+
+function Nifty(selector,options){
+if(niftyOk==false) return;
+if(niftyCss==false) AddCss('/plekit/niftycorner');
+var i,v=selector.split(","),h=0;
+if(options==null) options="";
+if(options.find("fixed-height"))
+    h=getElementsBySelector(v[0])[0].offsetHeight;
+for(i=0;i<v.length;i++)
+    Rounded(v[i],options);
+if(options.find("height")) SameHeight(selector,h);
+}
+
+function Rounded(selector,options){
+var i,top="",bottom="",v=new Array();
+if(options!=""){
+    options=options.replace("left","tl bl");
+    options=options.replace("right","tr br");
+    options=options.replace("top","tr tl");
+    options=options.replace("bottom","br bl");
+    options=options.replace("transparent","alias");
+    if(options.find("tl")){
+        top="both";
+        if(!options.find("tr")) top="left";
+        }
+    else if(options.find("tr")) top="right";
+    if(options.find("bl")){
+        bottom="both";
+        if(!options.find("br")) bottom="left";
+        }
+    else if(options.find("br")) bottom="right";
+    }
+if(top=="" && bottom=="" && !options.find("none")){top="both";bottom="both";}
+v=getElementsBySelector(selector);
+for(i=0;i<v.length;i++){
+    FixIE(v[i]);
+    if(top!="") AddTop(v[i],top,options);
+    if(bottom!="") AddBottom(v[i],bottom,options);
+    }
+}
+
+function AddTop(el,side,options){
+var d=CreateEl("b"),lim=4,border="",p,i,btype="r",bk,color;
+d.style.marginLeft="-"+getPadding(el,"Left")+"px";
+d.style.marginRight="-"+getPadding(el,"Right")+"px";
+if(options.find("alias") || (color=getBk(el))=="transparent"){
+    color="transparent";bk="transparent"; border=getParentBk(el);btype="t";
+    }
+else{
+    bk=getParentBk(el); border=Mix(color,bk);
+    }
+d.style.background=bk;
+d.className="niftycorners";
+p=getPadding(el,"Top");
+if(options.find("small")){
+    d.style.marginBottom=(p-2)+"px";
+    btype+="s"; lim=2;
+    }
+else if(options.find("big")){
+    d.style.marginBottom=(p-10)+"px";
+    btype+="b"; lim=8;
+    }
+else d.style.marginBottom=(p-5)+"px";
+for(i=1;i<=lim;i++)
+    d.appendChild(CreateStrip(i,side,color,border,btype));
+el.style.paddingTop="0";
+el.insertBefore(d,el.firstChild);
+}
+
+function AddBottom(el,side,options){
+var d=CreateEl("b"),lim=4,border="",p,i,btype="r",bk,color;
+d.style.marginLeft="-"+getPadding(el,"Left")+"px";
+d.style.marginRight="-"+getPadding(el,"Right")+"px";
+if(options.find("alias") || (color=getBk(el))=="transparent"){
+    color="transparent";bk="transparent"; border=getParentBk(el);btype="t";
+    }
+else{
+    bk=getParentBk(el); border=Mix(color,bk);
+    }
+d.style.background=bk;
+d.className="niftycorners";
+p=getPadding(el,"Bottom");
+if(options.find("small")){
+    d.style.marginTop=(p-2)+"px";
+    btype+="s"; lim=2;
+    }
+else if(options.find("big")){
+    d.style.marginTop=(p-10)+"px";
+    btype+="b"; lim=8;
+    }
+else d.style.marginTop=(p-5)+"px";
+for(i=lim;i>0;i--)
+    d.appendChild(CreateStrip(i,side,color,border,btype));
+el.style.paddingBottom=0;
+el.appendChild(d);
+}
+
+function CreateStrip(index,side,color,border,btype){
+var x=CreateEl("b");
+x.className=btype+index;
+x.style.backgroundColor=color;
+x.style.borderColor=border;
+if(side=="left"){
+    x.style.borderRightWidth="0";
+    x.style.marginRight="0";
+    }
+else if(side=="right"){
+    x.style.borderLeftWidth="0";
+    x.style.marginLeft="0";
+    }
+return(x);
+}
+
+function CreateEl(x){
+return(document.createElement(x));
+}
+
+function FixIE(el){
+if(el.currentStyle!=null && el.currentStyle.hasLayout!=null && el.currentStyle.hasLayout==false)
+    el.style.display="inline-block";
+}
+
+function SameHeight(selector,maxh){
+var i,v=selector.split(","),t,j,els=[],gap;
+for(i=0;i<v.length;i++){
+    t=getElementsBySelector(v[i]);
+    els=els.concat(t);
+    }
+for(i=0;i<els.length;i++){
+    if(els[i].offsetHeight>maxh) maxh=els[i].offsetHeight;
+    els[i].style.height="auto";
+    }
+for(i=0;i<els.length;i++){
+    gap=maxh-els[i].offsetHeight;
+    if(gap>0){
+        t=CreateEl("b");t.className="niftyfill";t.style.height=gap+"px";
+        nc=els[i].lastChild;
+        if(nc.className=="niftycorners")
+            els[i].insertBefore(t,nc);
+        else els[i].appendChild(t);
+        }
+    }
+}
+
+function getElementsBySelector(selector){
+var i,j,selid="",selclass="",tag=selector,tag2="",v2,k,f,a,s=[],objlist=[],c;
+if(selector.find("#")){ //id selector like "tag#id"
+    if(selector.find(" ")){  //descendant selector like "tag#id tag"
+        s=selector.split(" ");
+        var fs=s[0].split("#");
+        if(fs.length==1) return(objlist);
+        f=document.getElementById(fs[1]);
+        if(f){
+            v=f.getElementsByTagName(s[1]);
+            for(i=0;i<v.length;i++) objlist.push(v[i]);
+            }
+        return(objlist);
+        }
+    else{
+        s=selector.split("#");
+        tag=s[0];
+        selid=s[1];
+        if(selid!=""){
+            f=document.getElementById(selid);
+            if(f) objlist.push(f);
+            return(objlist);
+            }
+        }
+    }
+if(selector.find(".")){      //class selector like "tag.class"
+    s=selector.split(".");
+    tag=s[0];
+    selclass=s[1];
+    if(selclass.find(" ")){   //descendant selector like tag1.classname tag2
+        s=selclass.split(" ");
+        selclass=s[0];
+        tag2=s[1];
+        }
+    }
+var v=document.getElementsByTagName(tag);  // tag selector like "tag"
+if(selclass==""){
+    for(i=0;i<v.length;i++) objlist.push(v[i]);
+    return(objlist);
+    }
+for(i=0;i<v.length;i++){
+    c=v[i].className.split(" ");
+    for(j=0;j<c.length;j++){
+        if(c[j]==selclass){
+            if(tag2=="") objlist.push(v[i]);
+            else{
+                v2=v[i].getElementsByTagName(tag2);
+                for(k=0;k<v2.length;k++) objlist.push(v2[k]);
+                }
+            }
+        }
+    }
+return(objlist);
+}
+
+function getParentBk(x){
+var el=x.parentNode,c;
+while(el.tagName.toUpperCase()!="HTML" && (c=getBk(el))=="transparent")
+    el=el.parentNode;
+if(c=="transparent") c="#FFFFFF";
+return(c);
+}
+
+function getBk(x){
+var c=getStyleProp(x,"backgroundColor");
+if(c==null || c=="transparent" || c.find("rgba(0, 0, 0, 0)"))
+    return("transparent");
+if(c.find("rgb")) c=rgb2hex(c);
+return(c);
+}
+
+function getPadding(x,side){
+var p=getStyleProp(x,"padding"+side);
+if(p==null || !p.find("px")) return(0);
+return(parseInt(p));
+}
+
+function getStyleProp(x,prop){
+if(x.currentStyle)
+    return(x.currentStyle[prop]);
+if(document.defaultView.getComputedStyle)
+    return(document.defaultView.getComputedStyle(x,'')[prop]);
+return(null);
+}
+
+function rgb2hex(value){
+var hex="",v,h,i;
+var regexp=/([0-9]+)[, ]+([0-9]+)[, ]+([0-9]+)/;
+var h=regexp.exec(value);
+for(i=1;i<4;i++){
+    v=parseInt(h[i]).toString(16);
+    if(v.length==1) hex+="0"+v;
+    else hex+=v;
+    }
+return("#"+hex);
+}
+
+function Mix(c1,c2){
+var i,step1,step2,x,y,r=new Array(3);
+if(c1.length==4)step1=1;
+else step1=2;
+if(c2.length==4) step2=1;
+else step2=2;
+for(i=0;i<3;i++){
+    x=parseInt(c1.substr(1+step1*i,step1),16);
+    if(step1==1) x=16*x+x;
+    y=parseInt(c2.substr(1+step2*i,step2),16);
+    if(step2==1) y=16*y+y;
+    r[i]=Math.floor((x*50+y*50)/100);
+    r[i]=r[i].toString(16);
+    if(r[i].length==1) r[i]="0"+r[i];
+    }
+return("#"+r[0]+r[1]+r[2]);
+}
diff --git a/plekit/php/details.php b/plekit/php/details.php
index 7649a32..91dc7b7 100644
--- a/plekit/php/details.php
+++ b/plekit/php/details.php
@@ -47,9 +47,9 @@ class PlekitDetails {
   // start the details area, with an optional caption
   function start ($caption="") { print $this->start_html("$caption");}
   function start_html ($caption="") {
-    $html="<table class=plc_details><thead>";
-    if ($caption) $html .= "<caption>$caption</caption>";
-    $html .= "</thead><tbody>";
+    $html="<table class='plc_details'>";
+    if ($caption) $html .= "<thead><caption>$caption</caption></thead>";
+    $html .= "<tbody>";
     return $html;
   }
 
@@ -124,7 +124,7 @@ class PlekitDetails {
       else $height=$this->height;
 
       $html="";
-      $html .= "<tr><th><label for=$form_varname>$title</label></th>";
+      $html .= "<tr><th><label for='$form_varname'>$title</label></th>";
       $html .= "<td>";
       // xxx hack: if input_type is select : user provides the input field verbatim
       if ( $input_type == "select" ) {
@@ -137,7 +137,7 @@ class PlekitDetails {
       } else {
 	// set id too 
 	$html .= "<input type='$input_type' name='$form_varname' id='$form_varname' value='$value'";
-	if ($width) $html .= " size=$width";
+	if ($width) $html .= " size='$width'";
 	// handle event callbacks
 	$html .= PlekitForm::attributes($options);
 	$html .= "/>";
@@ -162,7 +162,7 @@ class PlekitDetails {
   // 1 item, colspan=2
   function tr($title,$align=NULL) { print $this->tr_html($title,$align);}
   function tr_html($title,$align=NULL) {
-    $result="<tr><td colspan=2";
+    $result="<tr><td colspan='2'";
     if ($align) $result .= " style='text-align:$align'";
     $result .=">$title</td></tr>";
     return $result;
@@ -170,7 +170,7 @@ class PlekitDetails {
   
   // a dummy line for getting some air
   function space () { print $this->space_html(); }
-  function space_html () { return "<tr><td colspan=2>&nbsp;</td></tr>\n"; }
+  function space_html () { return "<tr><td colspan='2'>&nbsp;</td></tr>\n"; }
 
 }
 
diff --git a/plekit/php/form.php b/plekit/php/form.php
index 45a8d77..0f67002 100644
--- a/plekit/php/form.php
+++ b/plekit/php/form.php
@@ -28,12 +28,13 @@ class PlekitForm {
     if ( $url_values ) $values=array_merge($values,$url_values);
     $this->values=$values;
 
-    $this->method=$method;
+    // make strict xhtml happy
+    $this->method=strtolower($method);
   }
 
   function start () { print $this->start_html(); }
   function start_html () {
-    $html="<form method=$this->method action='$this->url' enctype='multipart/form-data'>";
+    $html="<form method='$this->method' action='$this->url' enctype='multipart/form-data'>";
     if ($this->values) 
       foreach ($this->values as $key=>$value) 
 	$html .= $this->hidden_html($key,$value);
@@ -63,7 +64,7 @@ class PlekitForm {
   static function input_html ($type,$name,$value,$options=NULL) {
     if ( ! $options) $options=array();
     $html="<input";
-    $html="<input type='$type' name='$name' value='$value'";
+    $html .= " type='$type' name='$name' value='$value'";
     $html .= PlekitForm::attributes ($options);
     $html .= "/>";
     return $html;
@@ -81,7 +82,7 @@ class PlekitForm {
     return "<label for=$name>$display</label>";
   }
   static function textarea_html ($name,$value,$cols,$rows) {
-    return "<textarea name='$name' cols=$cols rows=$rows>$value</textarea>";
+    return "<textarea name='$name' cols='$cols' rows='$rows'>$value</textarea>";
   }
  
   // selectors is an array of hashes with the following keys
diff --git a/plekit/php/linetabs.php b/plekit/php/linetabs.php
index 41f211e..f83241a 100644
--- a/plekit/php/linetabs.php
+++ b/plekit/php/linetabs.php
@@ -68,22 +68,26 @@ function plekit_linetabs ($array, $id=NULL) {
     $url_values=$split['values'];
 
     // create form
-    $method=$todo['method'];
-    print "<form name='$label' action='$url' method='$method'>";
+    $method=strtolower($todo['method']);
+    print "<form action='$url' method='$method'><fieldset>";
     // set values
     $values=$todo['values'];
     if ( ! $values) $values = array();
     if ($url_values) $values = array_merge($values,$url_values);
     if ( $values ) foreach ($values as $key=>$value) {
-	print "<input type=hidden name='$key' value='$value' />";
+	print "<input type='hidden' name='$key' value='$value' />";
       }
-    $tracer="class=linetabs-submit";
+    $tracer="class='linetabs-submit'";
     // image and its companions 'height' 
     if ($todo['image']) {
-      $type='type=image src="' . $todo['image'] . '"';
-      if ($todo['height']) $type.= ' height=' . $todo['height'];
+      $what=$todo['image'];
+      $type="type='image' src='$what'";
+      if ($todo['height']) {
+	$what=$todo['height'];
+	$type .= " height='$what'";
+      }
     } else {
-      $type='type=button value="' . $label . '"';
+      $type="type='button' value='$label'";
     }
     $bubble=$todo['bubble'];
     print "<span title='$bubble'>";
@@ -91,11 +95,11 @@ function plekit_linetabs ($array, $id=NULL) {
     if ($todo['confirm']) $message=$todo['confirm'] . " ?";
     print "<input $tracer $type onclick='linetabs_namespace.submit(\"$id\",\"$message\")' />";
     print "</span>";
-    print "</form></li>\n";
+    print "</fieldset></form></li>\n";
   }
   print '</ul>';
   print '</div>';
-  print "<p class='plc-minittabs'></p>\n";
+  print "<p class='linetabs'></p>\n";
 }
 
 ?>
diff --git a/plekit/php/table.php b/plekit/php/table.php
index 4072d2e..7adcb5f 100644
--- a/plekit/php/table.php
+++ b/plekit/php/table.php
@@ -138,14 +138,15 @@ EOF;
     $width=count($this->headers);
     $pagesize_text_id = $this->table_id . "_pagesize";
     $result= <<< EOF
-<tr class=pagesize_area><td class=pagesize_area colspan=$width><form class='pagesize'>
-   <input class='pagesize_input' type='text' id="$pagesize_text_id" value=$this->pagesize 
+<tr class='pagesize_area'><td class='pagesize_area' colspan='$width'>
+<form class='pagesize' action='satisfy_xhtml_validator'><fieldset>
+   <input class='pagesize_input' type='text' id="$pagesize_text_id" value='$this->pagesize'
       onkeyup='plekit_pagesize_set("$this->table_id","$pagesize_text_id", $this->pagesize);' 
-      size=3 maxlength=3 /> 
+      size='3' maxlength='3' /> 
   <label class='pagesize_label'> items/page </label>   
-  <img class='table_reset' src="/planetlab/icons/clear.png" 
+  <img class='table_reset' src="/planetlab/icons/clear.png" alt="reset visible size"
       onmousedown='plekit_pagesize_reset("$this->table_id","$pagesize_text_id",$this->pagesize_def);' />
-</form></td></tr>
+</fieldset></form></td></tr>
 EOF;
     return $result;
 }
@@ -157,18 +158,19 @@ EOF;
     $search_reset_id = $this->table_id . "_search_reset";
     $search_and_id = $this->table_id . "_search_and";
     $result = <<< EOF
-<tr class=search_area><td class=search_area colspan=$width><form class='table_search'>
+<tr class='search_area'><td class='search_area' colspan='$width'>
+<form class='table_search' action='satisfy_xhtml_validator'><fieldset>
    <label class='table_search_label'> Search </label> 
    <input class='table_search_input' type='text' id='$search_text_id'
       onkeyup='plekit_table_filter("$this->table_id","$search_text_id","$search_and_id");'
-      size=$this->search_width maxlength=256 />
+      size='$this->search_width' maxlength='256' />
    <label>and</label>
    <input id='$search_and_id' class='table_search_and' 
       type='checkbox' checked='checked' 
       onchange='plekit_table_filter("$this->table_id","$search_text_id","$search_and_id");' />
-   <img class='table_reset' src="/planetlab/icons/clear.png" 
-      onmousedown='plekit_table_filter_reset("$this->table_id","$search_text_id","$search_and_id");'>
-</form></td></tr>
+   <img class='table_reset' src="/planetlab/icons/clear.png" alt="reset search"
+      onmousedown='plekit_table_filter_reset("$this->table_id","$search_text_id","$search_and_id");' />
+</fieldset></form></td></tr>
 EOF;
     return $result;
   }
@@ -194,7 +196,7 @@ EOF;
   ////////////////////////////////////////
   function notes_area_html () {
     $default_notes =  array(
-	"Enter & or | in the search area to alternate between <bold>AND</bold> and <bold>OR</bold> search modes",
+	"Enter &amp; or | in the search area to switch between <span class='bold'>AND</span> and <span class='bold'>OR</span> search modes",
 	"Hold down the shift key to select multiple columns to sort");
 
     if ($this->notes)
@@ -229,7 +231,7 @@ EOF;
   public function cell_html ($text,$colspan=0,$align=NULL) {
     $result="";
     $result .= "<td";
-    if ($colspan) $result .= " colspan=$colspan";
+    if ($colspan) $result .= " colspan='$colspan'";
     if ($align) $result .= " style='text-align:$align'";
     $result .= ">$text</td>";
     return $result;
diff --git a/plekit/php/toggle.php b/plekit/php/toggle.php
index 3474b41..aac3c9d 100644
--- a/plekit/php/toggle.php
+++ b/plekit/php/toggle.php
@@ -6,6 +6,7 @@ require_once 'prototype.php';
 
 drupal_set_html_head('
 <script type="text/javascript" src="/plekit/toggle/toggle.js"></script>
+<script type="text/javascript" src="/plekit/niftycorner/niftycube.js"></script>
 <link href="/plekit/toggle/toggle.css" rel="stylesheet" type="text/css" />
 ');
 
@@ -71,9 +72,11 @@ class PlekitToggle {
     if ( ! $this->options['start-hidden'])	{ $x1=""; $x2=" style='display:none'"; }
     else					{ $x2=""; $x1=" style='display:none'"; }
     $image_id=$this->id_name('image-visible');
-    $html .= "<img id=$image_id class='plc-toggle-visible' src='/plekit/icons/toggle-visible.png'$x1>";
+    $html .= "<img id='$image_id' class='plc-toggle-visible' src='/plekit/icons/toggle-visible.png'$x1";
+    $html .= " alt='Hide this section' />";
     $image_id=$this->id_name('image-hidden');
-    $html .= "<img id=$image_id class='plc-toggle-hidden' src='/plekit/icons/toggle-hidden.png'$x2>";
+    $html .= "<img id='$image_id' class='plc-toggle-hidden' src='/plekit/icons/toggle-hidden.png'$x2";
+    $html .= " alt='Show this section' />";
     return $html;
   }
 
@@ -85,8 +88,8 @@ class PlekitToggle {
     if (empty($tagname)) $tagname="span";
     
     $html="<$tagname";
-    $html .= " id=$trigger_id";
-    $html .= " class=plc-toggle-trigger";
+    $html .= " id='$trigger_id'";
+    $html .= " class='plc-toggle-trigger'";
     if ($bubble) $html .= " title='$bubble'";
     $html .= " onclick=\"plc_toggle('$this->id')\"";
     $html .= ">";
@@ -101,8 +104,8 @@ class PlekitToggle {
     $area_id=$this->id_name('area');
     $html="";
     $html .= "<div";
-    $html .= " class=plc-toggle-area";
-    $html .= " id=$area_id";
+    $html .= " class='plc-toggle-area'";
+    $html .= " id='$area_id'";
     if ($this->options['start-hidden']) $html .= " style='display:none'";
     $html .= ">";
     return $html;
@@ -116,8 +119,13 @@ class PlekitToggle {
   /* if desired, you can embed the whole (trigger+area) in another div for visual effects */
   function container_start ()		{ print $this->container_start_html(); }
   function container_start_html ()	{ 
-    $html="<div class='plc-toggle-container'";
     $id=$this->id_name('container');
+
+    // side-effects on the header
+    $nifty_init = "<script> Event.observe(window,'load', function () { Nifty ('div#$id','big'); } ); </script>";
+    drupal_set_html_head($nifty_init);
+
+    $html="<div class='plc-toggle-container'";
     $html .= " id='$id'";
     $html .= ">";
     return $html;
diff --git a/plekit/table/table.css b/plekit/table/table.css
index 34bc799..c6bf723 100644
--- a/plekit/table/table.css
+++ b/plekit/table/table.css
@@ -12,6 +12,9 @@ table.plekit_table>thead>tr, table.plekit_table>tbody>tr {
 table.plekit_table>thead>tr.pagesize_area, table.plekit_table>thead>tr.search_area {
     border-left: 0px;
 }    
+table.plekit_table fieldset {
+    border: 0px; margin: 0px; padding: 0px;
+}    
 
 th.plekit_table {
     font: bold 10px/22px "Trebuchet MS", Verdana, Arial, Helvetica, sans-serif;
@@ -233,6 +236,10 @@ span.plekit_table_note_title {
     text-align: center;
 }
 
+span.bold {
+    font-weight:bold;
+}
+
 /* for IE */
 ul.fdtablePaginater {display:inline-block;}
 mul.fdtablePaginater {display:inline;}
diff --git a/plekit/toggle/toggle.css b/plekit/toggle/toggle.css
index 4988ee3..4560ba8 100644
--- a/plekit/toggle/toggle.css
+++ b/plekit/toggle/toggle.css
@@ -2,14 +2,18 @@
  $Id$
  */
 
-.plc-toggle-trigger {
-    padding-left: 15px;
-/*    text-align:center; */
+/* containers - work with nifty corners*/
+div.plc-toggle-container {
+    background-color: #E6E6E6;
+    padding: 20px;
+    margin: 10px;
 }
 
-/* containers */
-div.plc-toggle-container {
-    border:2px solid #ccc;
+.plc-toggle-trigger {
+    padding: 0;
+    margin: 20px;
+    font-weight: bold;
+    cursor: crosshair;
 }
 
 /* the buttons */
-- 
2.43.0