From 248e0be86488349b44b1f04b39a93017d4954f2d Mon Sep 17 00:00:00 2001
From: gggeek <giunta.gaetano@gmail.com>
Date: Thu, 10 Nov 2022 17:53:54 +0000
Subject: [PATCH] comments

---
 .github/workflows/ci.yml | 3 +++
 src/Helper/XMLParser.php | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 5d1f245e..bac24c17 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -24,6 +24,7 @@ jobs:
                 # @see https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners
                 # @todo fix: atm our tests fail when using ubuntu 20 (focal) and php 5.6 - 7.1, when using
                 #       an ssl stream context for connecting to localhost via https
+                # @todo ubuntu 18 is deprecated. move to 20
                 operating-system: ['ubuntu-18.04'] # @todo add 'windows-latest'
                 # @todo use an older version of phpunit to enable testing on php 5.3 - 5.5 . Also: we will most likely
                 #       have to resort to using shivammathur/setup-php@v2 instead of sury's ppa to get php installed
@@ -33,6 +34,7 @@ jobs:
                 uses: actions/checkout@v2
             # Although this action is useful, we prefer to use the same script to set up php that we use for the
             # docker image used for local testing. This allows us to make sure that script is always in good shape
+            # @todo shivammathur/setup-php@v2 allows us to test with php 5.3 - 5.5 and 8.2. Use it in those cases!
             #-
             #    uses: shivammathur/setup-php@v2
             #    with:
@@ -68,6 +70,7 @@ jobs:
             -
                 if: ${{ matrix.php != '7.4' }}
                 run: './vendor/bin/phpunit -v tests'
+            # @todo would it be useful to run a 2nd test with composer --prefer-lowest? After all the only dependencies we have are testing tools
             -
                 run: 'python3 demo/client/python/test.py'
             -
diff --git a/src/Helper/XMLParser.php b/src/Helper/XMLParser.php
index f6e79a9a..d3595c3a 100644
--- a/src/Helper/XMLParser.php
+++ b/src/Helper/XMLParser.php
@@ -315,7 +315,7 @@ class XMLParser
                         $this->_xh['ac'] = ''; // reset the accumulator
                         break;
                     }
-                // we do not support the <NIL/> extension, so
+                // if here, we do not support the <NIL/> extension, so
                 // drop through intentionally
                 default:
                     // INVALID ELEMENT: RAISE ISF so that it is later recognized!!!
-- 
2.47.0