From 47aaca882310cc40eff962652529b1bfcea6b431 Mon Sep 17 00:00:00 2001 From: Alex Wang Date: Wed, 9 Oct 2013 04:30:35 +0000 Subject: [PATCH] tests: Remove the unit test for "ovs-appctl coverage/show". Changes will be made to allow "ovs-appctl time/warp" wake up all threads. With that, all threads will try calling "coverage_run()". And it will be impossible to deterministically check the output of the "ovs-appctl coverage/show" command. Thus, this commit removes the unit test for the coverage/show command. Signed-off-by: Alex Wang Signed-off-by: Ethan Jackson Acked-by: Ethan Jackson --- tests/ofproto-dpif.at | 34 ---------------------------------- 1 file changed, 34 deletions(-) diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at index b70637326..87e3d0ef4 100644 --- a/tests/ofproto-dpif.at +++ b/tests/ofproto-dpif.at @@ -2839,40 +2839,6 @@ AT_CHECK([ovs-appctl bond/show | sed -n '/^.*may_enable:.*/p'], [0], [dnl may_enable: true ]) -OVS_VSWITCHD_STOP -AT_CLEANUP - -# Unit test for appctl coverage/show command -AT_SETUP([ofproto-dpif - coverage/show]) -OVS_VSWITCHD_START - -ovs-appctl time/stop -# before the first 5 seconds, nothing can be calculated but the total count. -# there should be two unixctl commands received, but the count of the "appctl -# coverage/show" command is not updated to the total. so there show only 1. -AT_CHECK([ovs-appctl coverage/show | sed -n '/^unixctl_received.*/p'], [], [dnl -unixctl_received 0.0/sec 0.000/sec 0.0000/sec total: 1 -]) - -ovs-appctl time/warp 5000 -# at first 5 second time instant, should have stats. -AT_CHECK([ovs-appctl coverage/show | sed -n '/^unixctl_received.*/p'], [], [dnl -unixctl_received 0.6/sec 0.050/sec 0.0008/sec total: 3 -]) - -for i in `seq 0 10`; do ovs-appctl time/warp 5000; done -# advance to first 1 minute time instant. -AT_CHECK([ovs-appctl coverage/show | sed -n '/^unixctl_received.*/p'], [], [dnl -unixctl_received 0.2/sec 0.250/sec 0.0042/sec total: 15 -]) - -ovs-appctl time/warp 60000 -# advance to next 1 minute time instant directly, should observe the per-minute -# rate drop. -AT_CHECK([ovs-appctl coverage/show | sed -n '/^unixctl_received.*/p'], [], [dnl -unixctl_received 0.4/sec 0.033/sec 0.0047/sec total: 17 -]) - OVS_VSWITCHD_STOP AT_CLEANUP -- 2.47.0