From 4be17953d79c73db8efdcefb81d14cb5e1a3afa8 Mon Sep 17 00:00:00 2001 From: Ethan Jackson Date: Wed, 21 Aug 2013 14:49:09 -0700 Subject: [PATCH 1/1] ofp-parse: Silence uninitialized use warnings with optimized gcc. MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit GCC 4.6.3 gets confused by the str_to_*() functions in ofp-parse and spits out the following warning. error: ‘priority’ may be used uninitialized in this function Signed-off-by: Ethan Jackson Acked-by: Ben Pfaff --- lib/ofp-parse.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/ofp-parse.c b/lib/ofp-parse.c index 5cb39f5a6..298347427 100644 --- a/lib/ofp-parse.c +++ b/lib/ofp-parse.c @@ -132,7 +132,7 @@ str_to_u64(const char *str, uint64_t *valuep) static char * WARN_UNUSED_RESULT str_to_be64(const char *str, ovs_be64 *valuep) { - uint64_t value; + uint64_t value = 0; char *error; error = str_to_u64(str, &value); @@ -246,7 +246,7 @@ parse_resubmit(char *arg, struct ofpbuf *ofpacts) table_s = strsep(&arg, ","); if (table_s && table_s[0]) { - uint32_t table_id; + uint32_t table_id = 0; char *error; error = str_to_u32(table_s, &table_id); @@ -598,10 +598,10 @@ parse_named_action(enum ofputil_action_code code, size_t orig_size = ofpacts->size; struct ofpact_tunnel *tunnel; char *error = NULL; - uint16_t ethertype; - uint16_t vid; - uint8_t pcp; - uint8_t tos; + uint16_t ethertype = 0; + uint16_t vid = 0; + uint8_t tos = 0; + uint8_t pcp = 0; switch (code) { case OFPUTIL_ACTION_INVALID: @@ -1184,7 +1184,7 @@ parse_ofp_str__(struct ofputil_flow_mod *fm, int command, char *string) value); } } else if (fields & F_PRIORITY && !strcmp(name, "priority")) { - uint16_t priority; + uint16_t priority = 0; error = str_to_u16(value, name, &priority); fm->priority = priority; -- 2.43.0