From 53509ad55c16816d7a88a5695853555c7ef3572e Mon Sep 17 00:00:00 2001 From: Ansis Atteka <aatteka@nicira.com> Date: Fri, 6 Apr 2012 17:35:12 -0700 Subject: [PATCH] datapath: Do not send notification if ovs_vport_set_options() failed There is no need to send a notification if ovs_vport_set_options() failed and ovs_vport_cmd_set() did not change anything. Issue#10285 Signed-off-by: Ansis Atteka <aatteka@nicira.com> --- datapath/datapath.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/datapath/datapath.c b/datapath/datapath.c index 7f3139401..2fe6fdd68 100644 --- a/datapath/datapath.c +++ b/datapath/datapath.c @@ -1883,6 +1883,8 @@ static int ovs_vport_cmd_set(struct sk_buff *skb, struct genl_info *info) err = ovs_vport_set_options(vport, a[OVS_VPORT_ATTR_OPTIONS]); if (!err) err = change_vport(vport, a); + else + goto exit_unlock; if (!err && a[OVS_VPORT_ATTR_UPCALL_PID]) vport->upcall_pid = nla_get_u32(a[OVS_VPORT_ATTR_UPCALL_PID]); -- 2.47.0