From 55c2b94431412e6ffb2010bad230f68373109e07 Mon Sep 17 00:00:00 2001 From: Ben Pfaff Date: Wed, 5 Sep 2012 10:18:56 -0700 Subject: [PATCH 1/1] extract-ofp-errors: Check that error codes are in the expected ranges. All real OpenFlow error codes are small numbers, and for Nicira extensions we've intentionally chosen large numbers. This commit adds a check that standard and extension codes are properly designated in the ofp-errors.h header. Signed-off-by: Ben Pfaff --- build-aux/extract-ofp-errors | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/build-aux/extract-ofp-errors b/build-aux/extract-ofp-errors index bd4ab9ed5..db28af839 100755 --- a/build-aux/extract-ofp-errors +++ b/build-aux/extract-ofp-errors @@ -238,6 +238,11 @@ def extract_ofp_errors(filenames): "NX1.2": ("OF1.2",)} if targets not in target_map: fatal("%s: unknown error domain" % targets) + if targets.startswith('NX') and code < 0x100: + fatal("%s: NX domain code cannot be less than 0x100" % dst) + if targets.startswith('OF') and code >= 0x100: + fatal("%s: OF domain code cannot be greater than 0x100" + % dst) for target in target_map[targets]: domain[target].setdefault(type_, {}) if code in domain[target][type_]: -- 2.43.0