From 62093bae13aa604a6e542ce327a3954d45760883 Mon Sep 17 00:00:00 2001 From: Ben Pfaff Date: Tue, 16 Dec 2008 16:07:41 -0800 Subject: [PATCH] Add reminder comment to lib/learning-switch.c. (This doesn't change the semantics of the code at all.) --- lib/learning-switch.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/learning-switch.c b/lib/learning-switch.c index 44d655d80..76636a7bf 100644 --- a/lib/learning-switch.c +++ b/lib/learning-switch.c @@ -457,11 +457,14 @@ process_packet_in(struct lswitch *sw, struct rconn *rconn, void *opi_) return; drop_it: - /* Set up a flow to drop packets, or just drop the packet if we don't set - * up flows at all. */ if (sw->max_idle >= 0) { + /* Set up a flow to drop packets. */ queue_tx(sw, rconn, make_add_flow(&flow, ntohl(opi->buffer_id), sw->max_idle, 0)); + } else { + /* Just drop the packet, since we don't set up flows at all. + * XXX we should send a packet_out with no actions if buffer_id != + * UINT32_MAX, to avoid clogging the kernel buffers. */ } return; } -- 2.43.0