From 6273244ac740f54d46163a169836544373d594d0 Mon Sep 17 00:00:00 2001 From: Jesse Gross Date: Fri, 9 Aug 2013 15:27:27 -0700 Subject: [PATCH] datapath: Fix typo in flow validation logic. A bit shift operation is using the value '11' instead of '1' as the starting value. This only makes validation weaker than it should be so unless userspace is trying to install an invalid flow there will be no effect. Signed-off-by: Jesse Gross Acked-by: Kyle Mestery --- datapath/flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath/flow.c b/datapath/flow.c index e610065f0..407535063 100644 --- a/datapath/flow.c +++ b/datapath/flow.c @@ -138,7 +138,7 @@ static bool ovs_match_validate(const struct sw_flow_match *match, /* Always allowed mask fields. */ mask_allowed |= ((1ULL << OVS_KEY_ATTR_TUNNEL) | (1ULL << OVS_KEY_ATTR_IN_PORT) - | (11ULL << OVS_KEY_ATTR_ETHERTYPE)); + | (1ULL << OVS_KEY_ATTR_ETHERTYPE)); /* Check key attributes. */ if (match->key->eth.type == htons(ETH_P_ARP) -- 2.47.0