From 71f7f69c052927ec676fa70d55a2296c7e859af6 Mon Sep 17 00:00:00 2001 From: Ben Pfaff Date: Wed, 2 Nov 2011 12:59:06 -0700 Subject: [PATCH] stream: Fix uninitialized values in stream_init(). stream_init() didn't initialize the remote_ip, remote_port, local_ip, or local_port members of the stream, so "unix" streams that don't have any of those would get random values instead. Reported-by: "Voravit T." Reported-by: Jari Sundell --- AUTHORS | 2 ++ lib/stream.c | 1 + 2 files changed, 3 insertions(+) diff --git a/AUTHORS b/AUTHORS index 4c24be14e..6713ad943 100644 --- a/AUTHORS +++ b/AUTHORS @@ -71,6 +71,7 @@ Henrik Amren henrik@nicira.com Jad Naous jnaous@gmail.com Jan Medved jmedved@juniper.net Janis Hamme janis.hamme@student.kit.edu +Jari Sundell sundell.software@gmail.com Jed Daniels openvswitch@jeddaniels.com Jeongkeun Lee jklee@hp.com Joan Cirer joan@ev0.net @@ -98,6 +99,7 @@ Stephen Hemminger shemminger@vyatta.com Takayuki HAMA t-hama@cb.jp.nec.com Teemu Koponen koponen@nicira.com Vishal Swarankar vishal.swarnkar@gmail.com +Voravit T. voravit@kth.se YAMAMOTO Takashi yamamoto@valinux.co.jp Yongqiang Liu liuyq7809@gmail.com kk yap yapkke@stanford.edu diff --git a/lib/stream.c b/lib/stream.c index 37b611000..8f567ca38 100644 --- a/lib/stream.c +++ b/lib/stream.c @@ -616,6 +616,7 @@ void stream_init(struct stream *stream, struct stream_class *class, int connect_status, const char *name) { + memset(stream, 0, sizeof *stream); stream->class = class; stream->state = (connect_status == EAGAIN ? SCS_CONNECTING : !connect_status ? SCS_CONNECTED -- 2.47.0