From 7a13bc004d124cdc38ffc5f3cb6d7b3aefe1763b Mon Sep 17 00:00:00 2001 From: Ben Pfaff Date: Tue, 24 Apr 2012 15:43:11 -0700 Subject: [PATCH] vswitchd: Drop 'need_refresh' member from struct iface. It's no longer useful. Signed-off-by: Ben Pfaff --- vswitchd/bridge.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index 86f1bef70..4fd55e942 100644 --- a/vswitchd/bridge.c +++ b/vswitchd/bridge.c @@ -87,7 +87,6 @@ struct iface { struct netdev *netdev; /* Network device. */ const char *type; /* Usually same as cfg->type. */ const struct ovsrec_interface *cfg; - bool need_refresh; /* Refresh iface after create. */ }; struct mirror { @@ -1242,7 +1241,6 @@ iface_create(struct bridge *br, struct if_cfg *if_cfg, int ofp_port) iface->ofp_port = -1; iface->netdev = NULL; iface->cfg = if_cfg->cfg; - iface->need_refresh = true; hmap_insert(&br->iface_by_name, &iface->name_node, hash_string(iface->name, 0)); list_push_back(&port->ifaces, &iface->port_elem); @@ -1302,11 +1300,10 @@ iface_create(struct bridge *br, struct if_cfg *if_cfg, int ofp_port) } } - /* Populate stats columns in new Interface rows. */ - if (iface->netdev && iface->need_refresh) { + /* Initially populate stats columns. */ + if (iface->netdev) { iface_refresh_stats(iface); iface_refresh_status(iface); - iface->need_refresh = false; } /* Delete the iface if we failed. */ -- 2.47.0