From 7f1ae832546a90b8b1eb46d564dc9dc360053157 Mon Sep 17 00:00:00 2001 From: Tony Mack Date: Thu, 21 Jun 2012 20:13:05 -0400 Subject: [PATCH] fix potential TypeError --- sfa/rspecs/elements/versions/pgv2Interface.py | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/sfa/rspecs/elements/versions/pgv2Interface.py b/sfa/rspecs/elements/versions/pgv2Interface.py index 1c16e976..29845913 100644 --- a/sfa/rspecs/elements/versions/pgv2Interface.py +++ b/sfa/rspecs/elements/versions/pgv2Interface.py @@ -6,13 +6,14 @@ class PGv2Interface: @staticmethod def add_interfaces(xml, interfaces): - for interface in interfaces: - if_elem = xml.add_instance('interface', interface, ['component_id', 'client_id']) - ips = interface.get('ips', []) - for ip in ips: - if_elem.add_instance('ip', {'address': ip.get('address'), - 'netmask': ip.get('netmask'), - 'type': ip.get('type')}) + if isinstance(interfaces, list): + for interface in interfaces: + if_elem = xml.add_instance('interface', interface, ['component_id', 'client_id']) + ips = interface.get('ips', []) + for ip in ips: + if_elem.add_instance('ip', {'address': ip.get('address'), + 'netmask': ip.get('netmask'), + 'type': ip.get('type')}) @staticmethod def get_interfaces(xml): -- 2.47.0