From 80e448834d1f57131c0751e299d1c7cef9761210 Mon Sep 17 00:00:00 2001 From: Ben Pfaff Date: Tue, 4 Feb 2014 08:07:45 -0800 Subject: [PATCH] dpif-netdev: Make a log message more detailed. This would have helped me track down a bug I was hunting just now. Signed-off-by: Ben Pfaff Acked-by: Andy Zhou --- lib/dpif-netdev.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index cb64bdc74..0268793cf 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -1033,7 +1033,10 @@ dpif_netdev_mask_from_nlattrs(const struct nlattr *key, uint32_t key_len, struct flow *mask) { if (mask_key_len) { - if (odp_flow_key_to_mask(mask_key, mask_key_len, mask, flow)) { + enum odp_key_fitness fitness; + + fitness = odp_flow_key_to_mask(mask_key, mask_key_len, mask, flow); + if (fitness) { /* This should not happen: it indicates that * odp_flow_key_from_mask() and odp_flow_key_to_mask() * disagree on the acceptable form of a mask. Log the problem @@ -1046,7 +1049,8 @@ dpif_netdev_mask_from_nlattrs(const struct nlattr *key, uint32_t key_len, ds_init(&s); odp_flow_format(key, key_len, mask_key, mask_key_len, NULL, &s, true); - VLOG_ERR("internal error parsing flow mask %s", ds_cstr(&s)); + VLOG_ERR("internal error parsing flow mask %s (%s)", + ds_cstr(&s), odp_key_fitness_to_string(fitness)); ds_destroy(&s); } -- 2.43.0