From 88374ec308d985b03d93c462514b6b29ae135388 Mon Sep 17 00:00:00 2001
From: gggeek <giunta.gaetano@gmail.com>
Date: Wed, 23 Nov 2022 16:19:14 +0000
Subject: [PATCH] enable CI tests on php 5.4, 5.5
---
.github/workflows/ci.yml | 9 +++------
NEWS | 11 +++++++++++
tests/6HTTPTest.php | 1 +
3 files changed, 15 insertions(+), 6 deletions(-)
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index bac24c17..d8fde51c 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -24,17 +24,14 @@ jobs:
# @see https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners
# @todo fix: atm our tests fail when using ubuntu 20 (focal) and php 5.6 - 7.1, when using
# an ssl stream context for connecting to localhost via https
- # @todo ubuntu 18 is deprecated. move to 20
- operating-system: ['ubuntu-18.04'] # @todo add 'windows-latest'
- # @todo use an older version of phpunit to enable testing on php 5.3 - 5.5 . Also: we will most likely
- # have to resort to using shivammathur/setup-php@v2 instead of sury's ppa to get php installed
- php: ['8.1', '8.0', '7.4', '7.3', '7.2', '7.1', '7.0', '5.6']
+ operating-system: ['ubuntu-20.04'] # @todo add 'windows-latest'
+ # @todo enable testing on php 5.3 - it requires use an older version of phpunit (and no yoast/phpunit-polyfills?)
+ php: ['8.1', '8.0', '7.4', '7.3', '7.2', '7.1', '7.0', '5.6', '5.5', '5.4']
steps:
-
uses: actions/checkout@v2
# Although this action is useful, we prefer to use the same script to set up php that we use for the
# docker image used for local testing. This allows us to make sure that script is always in good shape
- # @todo shivammathur/setup-php@v2 allows us to test with php 5.3 - 5.5 and 8.2. Use it in those cases!
#-
# uses: shivammathur/setup-php@v2
# with:
diff --git a/NEWS b/NEWS
index 154f6d3a..53787fdb 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,14 @@
+XML-RPC for PHP version xxx - unreleased
+
+* fixed: decoding of responses with latin-1 charset declared in the xml prolog but not in http headers, when on php 5.4, 5.5
+
+* fixed: DateTimeInterface is not present in php 5.4 (error introduced in ver. 4.8.1)
+
+* improved: CI tests now run on php versions 5.4, 5.5 besides all more recent ones
+
+* improved: the test container for local testing now defaults to php 7.4 on ubuntu 20 focal
+
+
XML-RPC for PHP version 4.8.1 - 2022/11/10
* improved: remove warnings with php 8.1 due to usage of strftime
diff --git a/tests/6HTTPTest.php b/tests/6HTTPTest.php
index b91fa5b8..2da8e48a 100644
--- a/tests/6HTTPTest.php
+++ b/tests/6HTTPTest.php
@@ -261,6 +261,7 @@ class HTTPTest extends ServerTest
if (version_compare(PHP_VERSION, '5.6.0', '<'))
{
+ /// @todo investigate: can we make this work?
$this->markTestSkipped('HTTPS via Socket known to fail on php 5.5 and earlier');
return;
}
--
2.47.0