From 89e3f9ccae8fefa45b693330810862f281746460 Mon Sep 17 00:00:00 2001 From: Ethan Jackson Date: Thu, 21 Feb 2013 19:13:16 -0800 Subject: [PATCH] in-band: Use "internal" netdev type for local ports. A bridge's local port always has type "internal", so opening it with type "system" can't be correct. This was causing upgrade problems. Specifically, in certain bridge topologies, if there was a manager set force-reload-kmod would fail. This is because the local port netdev would open in the in-band code with type "system", confusing the more important netdev_open() in iface_create(). Bug #15067. Signed-off-by: Ethan Jackson --- ofproto/in-band.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ofproto/in-band.c b/ofproto/in-band.c index 3b98005f0..1a08fcc0a 100644 --- a/ofproto/in-band.c +++ b/ofproto/in-band.c @@ -464,7 +464,7 @@ in_band_create(struct ofproto *ofproto, const char *local_name, int error; *in_bandp = NULL; - error = netdev_open(local_name, "system", &local_netdev); + error = netdev_open(local_name, "internal", &local_netdev); if (error) { VLOG_ERR("failed to initialize in-band control: cannot open " "datapath local port %s (%s)", local_name, strerror(error)); -- 2.43.0