From 98e77ae30ee318f8f978c7e721562320e4eec2e8 Mon Sep 17 00:00:00 2001 From: gggeek Date: Wed, 22 Feb 2023 12:21:02 +0000 Subject: [PATCH] comments --- .github/workflows/ci.yaml | 8 ++++++++ demo/server/server.php | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 04313c7f..b464bfbc 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -144,6 +144,9 @@ jobs: if [ -d /var/log/apache2 ]; then sudo cat /var/log/apache2/other_vhosts_access.log; fi sudo cat /var/log/php*.log + # Whenever a change is pushed to this library, we run as well the tests of all known packages depending on it, + # so that we can catch any (involuntary) breackage. + # NB: if any are detected, do not forget to mark the current versions of dependents as incompatible in composer.json test-dependencies: runs-on: ubuntu-20.04 strategy: @@ -157,6 +160,11 @@ jobs: - name: download dependency, build its test vm and run its tests against the current commit run: | systemctl list-units --all --type=service --no-pager | grep running + # We test against the latest available release of dependents. + # Arguably, we could (also?) test against their master branch, in case some fixes were pushed there + # and not released yet, which make them work ok with us, but those tend to be tested when pushing + # to them (and we do not push to dependents changes which make them use an unreleased version + # of us anyway) composer create-project --prefer-source --no-install --remove-vcs --stability=alpha "${{ matrix.dependency }}" . # avoid rewriting 'source' line - we should figure out how to use negative lookahed... sed -i -E -e 's|"phpxmlrpc/phpxmlrpc" *: *"source"|"phpxmlrpc/phpxmlrpc_": "source"|g' composer.json diff --git a/demo/server/server.php b/demo/server/server.php index 333ec45e..893bf9e5 100644 --- a/demo/server/server.php +++ b/demo/server/server.php @@ -32,7 +32,7 @@ use PhpXmlRpc\Server; // Most of the code used to implement the webservices, and their signatures, are stowed away in neatly organized files, // each demoing a different topic -// One of the simplest way of implementing webservices: as xml-rpc-aware methods of a php object +// One of the simplest ways of implementing webservices: as xml-rpc-aware methods of a php object $signatures1 = include(__DIR__.'/methodProviders/functions.php'); // Even simpler? webservices defined using php functions in the global scope: definitions of webservices used for -- 2.47.0